Regression : Scrollbars appear bigger than their default size.
Reported by
yfulgaon...@etouch.net,
Jul 14 2016
|
||||||
Issue descriptionChrome version : 54.0.2796.2 (Official Build) 677b7ff9c1739954e09b0bea21d75cdd1911d062-refs/branch-heads/2796@{#3} 32/64 bit OS : Windows (7,8,8.1,10) Precondition : Please enable 'Material Design history' flag from chrome://flags. What steps will reproduce the problem? 1) Launch chrome, go to chrome://md-settings or chrome://history and open devtools. 2) Resize devtools window to L.H.S and click on 'toggle device toolbar' button twice. 3) Observe the scroll bars. Actual : Scroll bars appear bigger than their default size. Expected : Scroll bars should always appear in their default size. This is a regression issue broken in 'M-54', below is the Manual regression and Narrow Bisect info: Good Build : 54.0.2794.0 Bad Build : 54.0.2795.0 Narrow Bisect : https://chromium.googlesource.com/chromium/src/+log/af2f49ba57ed217d06e69830f325c9ba7e7ce0bd..57b70dae30c2bc7d60e70efd8ebae83e01fe9119?pretty=fuller&n=10000 Suspecting : r404880 ? from Narrow Bisect. @dtapuska : Could you please help to reassign if your change is not the cause for this change. Note : 1. Above issue is reproducible for both chrome://md-settings and chrome://history pages (i.e Material history). 2. Above issue is not seen on Linux(14.04 LTS) and Mac(10.10.5, 10.11.4) OS.
,
Jul 14 2016
Apologies for the above comment. Accidentally added RB label. Thank you.
,
Jul 15 2016
yfulgaonkar@, Can you please set chrome://flags/#enable-pointer-events to "disabled" and compare the behavior to when it's "enabled" for the same bad build#54.0.2795.0? Thank you!
,
Jul 15 2016
Hmm. seems like this is not related to chrome://flags/#enable-pointer-events, i am seeing the same behavior even with "Pointer-events" disabled. Thank you!
,
Jul 18 2016
No it wasn't my change. But disabling this fixes it... Sending over to bsep@ commit f449a7f4828a5610b1e21b8d2e378555fa59ca7b author bsep <bsep@chromium.org> Wed Jul 13 01:24:25 2016 committer Commit bot <commit-bot@chromium.org> Wed Jul 13 01:26:16 2016 Enable use-zoom-for-dsf by default. BUG= 613414 Review-Url: https://codereview.chromium.org/2044963004 Cr-Commit-Position: refs/heads/master@{#404875}
,
Jul 18 2016
Also note; I didn't repro on linux. But I did on Windows.
,
Jul 18 2016
This looks similar to 628501, and it's plausible that use-zoom-for-dsf caused it, so I'll take a look.
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f commit d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Author: bsep <bsep@chromium.org> Date: Fri Jul 22 23:17:35 2016 Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG= 628501 , 628185 Review-Url: https://codereview.chromium.org/2168313002 Cr-Commit-Position: refs/heads/master@{#407294} [modify] https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
,
Jul 22 2016
,
Jul 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0585519c495685502d0b0168808193bd094a0de8 commit 0585519c495685502d0b0168808193bd094a0de8 Author: mpearson <mpearson@chromium.org> Date: Sat Jul 23 00:21:40 2016 Revert of Fix the mobile emulator to use the correct device scale when disabled. (patchset #1 id:1 of https://codereview.chromium.org/2168313002/ ) Reason for revert: Likely cause of webkit_tests unexpected_failures inspector/screen-orientation-override.html https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux/67873/layout-test-results/results.html Failure appeared on many bots: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux/builds/67873 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/15157 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/21002 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7468 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/12746 and it seems related (change to devtools, failure in "inspector") Original issue's description: > Fix the mobile emulator to use the correct device scale when disabled. > > The mobile emulator was triggering a layout before it had reapplied the > original viewport parameters when it was being disabled, which with > use-zoom-for-dsf enabled was causing the wrong viewport size to be given > to various components, like plugins and scrollbars. > > BUG= 628501 , 628185 > > Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f > Cr-Commit-Position: refs/heads/master@{#407294} TBR=dgozman@chromium.org,alph@chromium.org,bsep@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 628501 , 628185 Review-Url: https://codereview.chromium.org/2174493004 Cr-Commit-Position: refs/heads/master@{#407314} [modify] https://crrev.com/0585519c495685502d0b0168808193bd094a0de8/content/renderer/devtools/render_widget_screen_metrics_emulator.cc
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c78b3850f956c1507e4cdf9429652ee0ef15cb0 commit 1c78b3850f956c1507e4cdf9429652ee0ef15cb0 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jul 26 00:00:01 2016 Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG= 628501 , 628185 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/2168313002 . Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} [modify] https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0/content/renderer/devtools/render_widget_screen_metrics_emulator.cc [modify] https://crrev.com/1c78b3850f956c1507e4cdf9429652ee0ef15cb0/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt
,
Jul 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c00cb1de97175f2f023bd18b6792c9057de70dc1 commit c00cb1de97175f2f023bd18b6792c9057de70dc1 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Jul 26 00:24:07 2016 Fix the mobile emulator to use the correct device scale when disabled. The mobile emulator was triggering a layout before it had reapplied the original viewport parameters when it was being disabled, which with use-zoom-for-dsf enabled was causing the wrong viewport size to be given to various components, like plugins and scrollbars. BUG= 628501 , 628185 R=dgozman@chromium.org Review URL: https://codereview.chromium.org/2168313002 . Committed: https://crrev.com/d89c7a1578f9f16f6e1fa4375aab232b67fe0f9f Cr-Original-Commit-Position: refs/heads/master@{#407294} Cr-Commit-Position: refs/heads/master@{#407639} (cherry picked from commit 1c78b3850f956c1507e4cdf9429652ee0ef15cb0) Review URL: https://codereview.chromium.org/2183533003 . Cr-Commit-Position: refs/branch-heads/2785@{#351} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/c00cb1de97175f2f023bd18b6792c9057de70dc1/content/renderer/devtools/render_widget_screen_metrics_emulator.cc [modify] https://crrev.com/c00cb1de97175f2f023bd18b6792c9057de70dc1/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt
,
Sep 1 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by msrchandra@chromium.org
, Jul 14 2016