New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628159 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jul 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser gets crashed on double clicking Reset button in chrome://md-settings page

Project Member Reported by bj00129...@techmahindra.com, Jul 14 2016 
Version: 54.0.2796.2 Dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Launch Chrome>>Naviagte to chrome://md-settings/advanced page>>Clcik on reset>>Now double click on reset button in reset overlay and observe.

Expected:Browser should not crash upon double clicking on reset button. 
Actual:Instead browser crash is seen.

Crash Id:e604ac7600000000

This is Regression issue broken in M-48.
Good build:48.0.2560.0
Bad build:48.0.2561.0

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/735c8cec4a33952971c3b1d02f1536467422ddc9..ab5ac91aaa08b025426c37a55cb7637593eb27b8

Suspecting  https://codereview.chromium.org/1418803004 from changelog.

@dpapad- Please help in reassiging if it is not related to your change.

Attaching screencast for reference.
Actual_Reset.ogv
2.4 MB View Download
Expected_Reset.ogv
1.9 MB View Download

Comment 1 by kavvaru@chromium.org, Jul 14 2016

Labels: OS-Mac
Able to reproduce the issue on Mac 10.11.5 using chrome version 54.0.2795.0

Stack trace
===================
Thread 0 CRASHED [SIGILL @ 0x00007fcc291b2a34 ] MAGIC SIGNATURE THREAD
0x00007fcc291b2a34	(chrome -./out/Release/../../chrome/browser/profile_resetter/profile_resetter.cc:100 )	<name omitted>
0x00007fcc2943f1f1	(chrome -./out/Release/../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1045 )	tc_malloc
0x00007fcc287157f6	(chrome -./out/Release/../../chrome/browser/ui/webui/settings/reset_settings_handler.cc:215 )	settings::ResetSettingsHandler::ResetProfile
0x00007fcc28715a4f	(chrome + 0x04811a4f )	
0x00007fcc287151fc	(chrome -./out/Release/../../chrome/browser/ui/webui/settings/reset_settings_handler.cc:123 )	settings::ResetSettingsHandler::HandleResetProfileSettings
0x00007fcc253202e8	(chrome -./out/Release/../../base/callback.h:389 )	<name omitted>
0x00007fcc25320a3f	(chrome + 0x0141ca3f )	
0x00007fcc25320b72	(chrome -./out/Release/../../base/tuple.h:140 )	<name omitted>
0x00007fcc253209cf	(chrome -./out/Release/../../content/browser/webui/web_ui_impl.cc:91 )	<name omitted>
0x00007fcc29b5e49c	(chrome + 0x05c5a49c )	_fini
0x00007fcc29b5ed48	(chrome + 0x05c5ad48 )	_fini
0x00007fcc25320980	(chrome -./out/Release/../../content/browser/webui/web_ui_impl.cc:91 )	<name omitted>
0x00007fcc2530c709	(chrome -./out/Release/../../content/browser/web_contents/web_contents_impl.cc:638 )	<name omitted>
0x00007fcc27ef083f	(chrome -./out/Release/../../ui/touch_selection/touch_selection_controller.cc:82 )	<name omitted>
0x00007fcc25248026	(chrome -./out/Release/../../cc/input/selection.h:15 )	<name omitted>
0x00007fcc24a03537	(chrome -./out/Release/../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:98 )	<name omitted>
0x00007fcc27fd4658	(chrome -./out/Release/../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_tree.h:639 )	IPC::ParamTraits<cc::DelegatedFrameData>::Read

Comment 2 by dpa...@chromium.org, Jul 14 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e921d98243a6aa5a481436ec300f83942e376d0

commit 7e921d98243a6aa5a481436ec300f83942e376d0
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 14 20:24:16 2016

MD Settings: Disallow clicking on "Reset" when resetting profile is in progress.

Fixes browser crash.

BUG= 628159 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150983002
Cr-Commit-Position: refs/heads/master@{#405554}

[modify] https://crrev.com/7e921d98243a6aa5a481436ec300f83942e376d0/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/7e921d98243a6aa5a481436ec300f83942e376d0/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/7e921d98243a6aa5a481436ec300f83942e376d0/chrome/test/data/webui/settings/reset_page_test.js

Comment 4 by dbeam@chromium.org, Jul 15 2016

Status: Fixed (was: Started)
►

Sign in to add a comment