New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628156 link

Starred by 3 users
Status: Fixed
Owner:
charliea@chromium.org
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Can't close the chrome:tracing "help" dialog after the first time it's been closed

Reported by adha...@etouch.net, Jul 14 2016 
Chrome Version:54.0.2796.2 (Official Build) 677b7ff9c1739954e09b0bea21d75cdd1911d062-refs/branch-heads/2796@{#3} (32/64-bit)
OS:Windows(7,8,10),Mac(10.10.5, 10.11.4),Linux(14.04 LTS)

What steps will reproduce the problem?
(1)Launch Chrome and navigate to chrome://tracing.
(2)Click on help icon (?)
(3)Resize the window few times(At least 5 times)using minimize/maximize option.
(4)Click on 'close' button of 'help' overlay and observe.

Actual:'Help' overlay does not close after Step 4.

Expected:'Help' overlay should close after step 4.

This is a Regression issue broken in M-54,will soon update other info.

Comment 1 by adha...@etouch.net, Jul 14 2016

Owner: sullivan@chromium.org
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/57b70dae30c2bc7d60e70efd8ebae83e01fe9119..53cad58eb3957b6b3a96d171fac008d93dd82fc1?pretty=fuller&n=100

Suspecting:r404903?

Good build:54.0.2794.0
Bad build:54.0.2795.0

Kindly help to re-assign if your change is not the cause for this issue
Actual result.mp4
2.2 MB View Download
Expected result.mp4
1.6 MB View Download

Comment 2 by adha...@etouch.net, Jul 14 2016

Status: Assigned (was: Unconfirmed)

Comment 3 by sullivan@chromium.org, Jul 14 2016

Owner: charliea@chromium.org
Charlie, can you take a look?

Comment 4 by msrchandra@chromium.org, Jul 14 2016

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if it is not required.
Thank You.

Comment 5 by charliea@chromium.org, Jul 14 2016 

Was able to reproduce this on ToT catapult. Looking into it now.

Comment 7 by charliea@chromium.org, Jul 14 2016

Summary: Can't close the chrome:tracing "help" dialog after the first time it's been closed (was: Regression:'Help' overlay does not close after clicking the 'close' button in chrome://tracing)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/837ddb07ceee0853ca25a124c5d0b61550f21f41

commit 837ddb07ceee0853ca25a124c5d0b61550f21f41
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Jul 14 15:39:05 2016

Roll src/third_party/catapult/ 94d2faa8c..ad2572019 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/94d2faa8c3fb..ad257201962e

$ git log 94d2faa8c..ad2572019 --date=short --no-merges --format='%ad %ae %s'

BUG= 628156 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2151883002
Cr-Commit-Position: refs/heads/master@{#405499}

[modify] https://crrev.com/837ddb07ceee0853ca25a124c5d0b61550f21f41/DEPS

Comment 9 by charliea@chromium.org, Jul 15 2016 

Can anyone help me figure out what's needed to cherry-pick this change to the release branch? I fixed it in https://codereview.chromium.org/2144013003

Comment 10 by ajha@chromium.org, Jul 18 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2799.0
The fix is working as intended on the latest canary(54.0.2799.0 /master@{#405947}) of Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04. Able to close the help dialog after resizing the browser window multiple times.

charliea@: Please close the issue as the issue is regressed in M-54 and is fixed in the latest canary.

Comment 11 by charliea@chromium.org, Jul 19 2016

Status: Fixed (was: Assigned)
Ah, great. Marking as fixed.
►

Sign in to add a comment