New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628143 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

PaymentRequestNoShippingTest#testCancelUnmaskAndRetry is flaky

Project Member Reported by mlamouri@chromium.org, Jul 14 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dc78cbdcc775a00ad9dcde81d7ea36ee37a72c2

commit 7dc78cbdcc775a00ad9dcde81d7ea36ee37a72c2
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Jul 14 10:13:09 2016

Mark PaymentRequestNoShippingTest#testCancelUnmaskAndRetry as flaky.

BUG= 628143 
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2149913002
Cr-Commit-Position: refs/heads/master@{#405462}

[modify] https://crrev.com/7dc78cbdcc775a00ad9dcde81d7ea36ee37a72c2/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java

Cc: -rouslan@chromium.org dfalcant...@chromium.org
Owner: rouslan@chromium.org
Status: Started (was: Assigned)
A newly added test is failing an assert.
Labels: Merge-Request-53 M-53
Would like to merge c06f5513dc0d40f7dbd2f7c1d52490f8777ed321 into M-53.

Comment 6 by dimu@google.com, Jul 18 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60b5147bb728a84a8a775adb5f0360259ac79ddf

commit 60b5147bb728a84a8a775adb5f0360259ac79ddf
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Mon Jul 18 17:05:46 2016

Clear callback pointer after using it in AutofillPaymentInstrument.

BUG= 628143 

Review-Url: https://codereview.chromium.org/2151883003
Cr-Commit-Position: refs/heads/master@{#405517}
(cherry picked from commit c06f5513dc0d40f7dbd2f7c1d52490f8777ed321)

Review URL: https://codereview.chromium.org/2158793005 .

Cr-Commit-Position: refs/branch-heads/2785@{#181}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/60b5147bb728a84a8a775adb5f0360259ac79ddf/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java

Status: Fixed (was: Started)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment