New issue
Advanced search Search tips

Issue 628116 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.2% regression in speedometer at 405221:405223

Project Member Reported by nikolaos@chromium.org, Jul 14 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=628116

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgisCwqwoM


Bot(s) for this bug's original alert(s):

chromium-rel-win7-x64-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 14 2016

Cc: dbeam@chromium.org
Owner: dbeam@chromium.org

=== Auto-CCing suspected CL author dbeam@chromium.org ===

Hi dbeam@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Revert of Color: Don't duplicate ICC profile data (patchset #3 id:40001 of https://codereview.chromium.org/2140803002/ )
Author  : dbeam
Commit description:
  
Reason for revert:
Broke static initializers step of sizes on Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/22278

Maybe making map_ a base::LazyInstance would solve your problem?

Original issue's description:
> Color: Don't duplicate ICC profile data
>
> Make gfx::ColorSpace have an internal pointer to a globally-unique
> structure for the color space, where its ICC profile can be stored.
>
> BUG= 622133 
>
> Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
> Cr-Commit-Position: refs/heads/master@{#405211}

TBR=hubbe@chromium.org,ccameron@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 622133 

Review-Url: https://codereview.chromium.org/2148013002
Cr-Commit-Position: refs/heads/master@{#405221}
Commit  : 075682d2247db4715899446dfcebd22ba952882a
Date    : Wed Jul 13 19:25:09 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@405220  236.869  4.40523  27  good
chromium@405221  239.097  3.45513  27  bad    <--
chromium@405222  239.584  4.29269  27  bad
chromium@405223  240.403  4.10169  27  bad

Bisect job ran on: win_x64_perf_bisect
Bug ID: 628116

Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests speedometer
Test Metric: VanillaJS-TodoMVC/VanillaJS-TodoMVC
Relative Change: 1.43%
Score: 95.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_x64_perf_bisect/builds/1321
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007175568987085568


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5859689133244416

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by dbeam@chromium.org, Jul 14 2016

Status: WontFix (was: Assigned)

Sign in to add a comment