New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628104 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jan 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support struct as key of map in mojom

Project Member Reported by leon....@intel.com, Jul 14 2016

Issue description

Currently mojom map<K,V> only supports K as string or a numeric type. But during chromium IPC mojofication, we may encounter some maps whose key types are some user-defined structs.

This issue is to track the work to support struct as key of mojom map.
 

Comment 1 by leon....@intel.com, Jul 14 2016

Cc: yzshen@chromium.org dcheng@chromium.org

Comment 2 by yzshen@chromium.org, Aug 15 2016

Cc: tibell@chromium.org

Comment 3 by tibell@chromium.org, Aug 15 2016

Leon, are you working on this? Otherwise I might have some free cycles.

Comment 4 by leon....@intel.com, Aug 16 2016

OK, Thanks Johan a lot for the help. Actually I tried to investigate around but have no clear idea yet.. Let me study how you would do, thanks ;-)

Comment 5 by leon....@intel.com, Aug 16 2016

Cc: -tibell@chromium.org leon....@intel.com
Owner: tibell@chromium.org

Comment 6 by tibell@chromium.org, Sep 12 2016

It would be great to have some examples of where this might be needed. I only find

https://cs.chromium.org/chromium/src/components/autofill/content/public/interfaces/autofill_types.mojom?l=196

and from a casual look at the code that uses this map a vector of pairs would be fine, because there's no lookup. I also suspect this example might not be the best one for using a map in Mojo as the key type is *huge* and probably really inefficient to hash, compare for equality, and copy.

Comment 8 by tibell@chromium.org, Oct 23 2016

This is now done for C++ and Java. Since JS maps uses object identity for keys the best we can do is support sending data as maps, but the only thing users can do with those maps is iterate over them.
Cc: fmea...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Components: Internals>Mojo
Components: -Internals>Mojo Internals>Mojo>Bindings
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 3

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold
Status: WontFix (was: Untriaged)
JS support is not practical, and C++/Java support was implemented.

Sign in to add a comment