New issue
Advanced search Search tips

Issue 628088 link

Starred by 1 user
Status: Duplicate
Merged: issue 618784
Owner: ----
Closed: Jul 2016
Cc:
tandrii@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Remove CQ+{1, 2} if test failed

Project Member Reported by shinyak@chromium.org, Jul 14 2016 
I feel it is good if the result of CQ failure is clearer. We need to read the CommitBot message carefully now.

When CQ failed, it would be good to remove CQ+1 or CQ+2 automatically.

Comment 1 by tandrii@chromium.org, Jul 14 2016 

Two things:
 * have you considered making CQ set special label (-1/+1) depending on the result? The cq.cfg option is called cq_verified_label: https://chrome-internal.googlesource.com/infra/infra_internal/+/master/commit_queue/cq_client/cq.proto#104

  * CQ removing original CQ triggering votes is tracked here:  issue 618784

Comment 2 by shinyak@chromium.org, Jul 15 2016

Mergedinto: 618784
Status: Duplicate (was: Untriaged)
Oh, thanks. That 2 things are perfectly what I want!

The first one is already implemented and the second one is tracked in another issue, then this issue should be closed as invalid or duplicate. thanks.
►

Sign in to add a comment