Changelog url: (Unable to narrow down range as issue is not reproducible on chromium builds )

https://chromium.googlesource.com/chromium/src/+log/54.0.2794.0..54.0.2795.0?pretty=fuller&n=10000

Suspecting: r405033 ?

Please help to re-assign if your change is not the cause for this issue.

Deleted: Actual_Expected_result.jpg 114 KB

	Actual_Expected_result.jpg 114 KB View Download

Added Release Block Dev label as the Google Logo is broken and this is a recent Regression. Please remove if it is not required.
Thank You.

I doubt it's r405033. The issue is a missing image, not painting of the image.

DevTools says this image is "chrome://theme/IDR_PRODUCT_LOGO" and that it is missing (or at least DevTools cannot see it). There were a bunch of changes in parsing and loading code which might explain this, but it would be excellent if someone could check the obvious thing of whether the resource has somehow been dropped or lost.

Regardless, the fact that we don't have problem with any other images suggests that the issue is with the UI pages or the way we process them. I don't know what the right component is.

Looping https://cs.chromium.org/chromium/src/chrome/browser/themes/OWNERS for further inputs.

Thank you!

Issue is also seen in CrOS with 54.0.2796.4/8589.0.0 (Official Build) dev-channel daisy_spring,pit,quawks.

Issue is seen both in OOBE screen and chrome://version page. i.e;Chrome logo is missing.

Note: Above issue is also seen on chrome://apps page. Please refer the attached screenshot

Deleted: Actual_apps.jpg 104 KB

	Actual_apps.jpg 104 KB View Download

 Issue 628440  has been merged into this issue.

As noted in  Issue 628440 , this hits a NOTREACHED in ThemeSource::StartDataRequest:

https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/theme_source.cc?q=theme_source.cc&sq=package:chromium&l=150

I got as far as figuring out that the line for IDR_PRODUCT_LOGO is simply missing from the autogenerated file components_scaled_resources_map.cc (at least in my local build):

https://cs.chromium.org/chromium/src/out/Debug/gen/components/grit/components_scaled_resources_map.cc?q=IDR_PRODUCT_LOGO&sq=package:chromium&dr=C&l=27

I'll run a bisect and see if I can find the cause....

Here's a CL that describes the problem, and may or may not contain a good fix for it:
https://codereview.chromium.org/2149233005/

And unfortunately even if we built a test to navigate to chrome://version, we won't catch this because there's no bot that does: official builds + dcheck enabled + run tests.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1be5656fff449c3d2ad654c21fb33df30e4becea

commit 1be5656fff449c3d2ad654c21fb33df30e4becea
Author: glevin <glevin@chromium.org>
Date: Fri Jul 15 23:10:15 2016

Fix bug with 'not' flags in _FormatSource()

BUG= 628086 
TEST=See bug, check that logo has reappeared.  Alternately, run in debug
mode and observe that program doesn't crash at startup.

Review-Url: https://codereview.chromium.org/2149233005
Cr-Commit-Position: refs/heads/master@{#405892}

[modify] https://crrev.com/1be5656fff449c3d2ad654c21fb33df30e4becea/tools/grit/grit/format/resource_map.py

Fix landed. Grit unit test pending: https://codereview.chromium.org/2153763005/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3994f4bcd09f300a54e70a3f75eca8661e6b5ba6

commit 3994f4bcd09f300a54e70a3f75eca8661e6b5ba6
Author: thestig <thestig@chromium.org>
Date: Mon Jul 18 19:36:50 2016

Modify grit unit tests to test for missing resources.

This is a follow up to the fix in r405892. Also cleanup some nits.

BUG= 628086 

Review-Url: https://codereview.chromium.org/2153763005
Cr-Commit-Position: refs/heads/master@{#406066}

[modify] https://crrev.com/3994f4bcd09f300a54e70a3f75eca8661e6b5ba6/tools/grit/grit/format/resource_map.py
[modify] https://crrev.com/3994f4bcd09f300a54e70a3f75eca8661e6b5ba6/tools/grit/grit/format/resource_map_unittest.py

Verified on ChromeOS  8697.0.0, 54.0.2826.0