New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628080 link

Starred by 4 users
Status: Fixed
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus is seen on previous 'Actions' icon even after clicking on another in Chrome://history page.

Reported by rk...@etouch.net, Jul 14 2016 
Chrome Version: 54.0.2795.0 Revision ad659671899c8629433fc7904e109ab34f15eafd-refs/heads/master@{#405182} 
OS: Mac (10.10.5)(10.11.4)

Pr-condition: 1. Enable Material Design history flag from chrome://flags.
               2. Create history by navigating any webpage.

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://history page.
(2) Click on 'Actions' icon of any link(Overlay opened), then click on 'Actions' icon of another link
(3) Then press Esc key and observe.

Focus is seen on previous 'Actions' icon after pressing Esc key.

Focus should not stay on previous 'Actions' icon.

This is a regression issue,broken in 'M-54', will soon update the other info.

Comment 1 by rk...@etouch.net, Jul 14 2016

Labels: hasbisect
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression: Focus is seen on previous 'Actions' icon even after clicking on another in Chrome://history page. (was: Regression: Focus issue observed on Chrome://history page.)
Good build:54.0.2794.0
Bad build: 54.0.2795.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/bdf7241b6babfab7e3c1970c508ba43a306a3b47..f92b62a5dd9fa3ce8cb57c6711f52bb14dccd758?pretty=fuller&n=100

Suspecting: r405048
Actual_History.mov
1010 KB Download

Comment 2 by tsergeant@chromium.org, Jul 15 2016

Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03a7e9b1731415b78007c697f1e4402f5510f843

commit 03a7e9b1731415b78007c697f1e4402f5510f843
Author: tsergeant <tsergeant@chromium.org>
Date: Tue Aug 02 06:07:13 2016

MD WebUI: Do not restore focus from <cr-shared-menu> when closing with tap

This fixes issues where focus would move around unexpectedly while
interacting with the menu using a mouse. Focus will still restore when
the menu is closed with escape or the closeMenu function.

BUG= 628080 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2202133002
Cr-Commit-Position: refs/heads/master@{#409145}

[modify] https://crrev.com/03a7e9b1731415b78007c697f1e4402f5510f843/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/03a7e9b1731415b78007c697f1e4402f5510f843/chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js
[modify] https://crrev.com/03a7e9b1731415b78007c697f1e4402f5510f843/ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js

Comment 4 by tsergeant@chromium.org, Aug 2 2016

Status: Fixed (was: Assigned)

Comment 5 by ssamanoori@chromium.org, Aug 9 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2824.0
Tested the issue on Mac 10.11.6 using 54.0.2824.0.Observed that focus is not seen on previous 'Actions' icon after pressing Esc key.
Please find attached screencast.

Marking it as TE-Verified.
628080.mp4
767 KB View Download
►

Sign in to add a comment