Spinner for updating device has visual glitch with md-settings
Reported by
ringosta...@gmail.com,
Jul 14 2016
|
||||
Issue description
,
Jul 18 2016
This is unfortunately caused by https://github.com/PolymerElements/iron-icon/issues/67. We use the "src" attribute to display the throbber, and the "icon" attribute to display the remaining icons. When setting "icon" to null, it unfortunately does not fully clear the previously displayed icon (see attachment where the checkmark icon is visible if the zoom level is increased quite a bit).
,
Jul 18 2016
FYI, I have a candidate fix. Will send a PR.
,
Jul 19 2016
There is already a PR that fixes the issue at https://github.com/PolymerElements/iron-iconset-svg/pull/44. Need to ensure that this PR lands, since it has been sitting around for a few months.
,
Jul 25 2016
Issue 630336 has been merged into this issue.
,
Oct 12 2016
i'll try to roll in the github PR
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/621fabaed32c36e94621eef310fda26830235f0d commit 621fabaed32c36e94621eef310fda26830235f0d Author: dbeam <dbeam@chromium.org> Date: Wed Oct 12 19:07:43 2016 Roll Polymer element iron-iconset-svg, 1.0.9 -> 1.0.11 to pick up: https://github.com/PolymerElements/iron-iconset-svg/pull/44 TBR=dpapad@chromium.org BUG= 628071 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2413613002 Cr-Commit-Position: refs/heads/master@{#424813} [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/chrome/browser/resources/md_downloads/crisper.js [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/third_party/polymer/v1_0/components-chromium/iron-iconset-svg/bower.json [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/third_party/polymer/v1_0/components-chromium/iron-iconset-svg/iron-iconset-svg-extracted.js [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/third_party/polymer/v1_0/components-chromium/paper-icon-button/paper-icon-button-light.html [modify] https://crrev.com/621fabaed32c36e94621eef310fda26830235f0d/third_party/polymer/v1_0/components_summary.txt
,
Oct 13 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tbuck...@chromium.org
, Jul 18 2016Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)