New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628056 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocked on:
issue 631242



Sign in to add a comment

installer failure on win64 official builder after flipping to GN

Project Member Reported by dpranke@chromium.org, Jul 14 2016

Issue description

Cc: -sebmarchand@chromium.org
Owner: sebmarchand@chromium.org
I'm looking at this !

Comment 2 by grt@chromium.org, Jul 14 2016

Cc: grt@chromium.org
Status: Started (was: Untriaged)
For the record, I told sebmarchand this about "First Run": "i believe this file was created as part of the build process so that developers running out\Rel\chrome.exe to test out their feature under development wouldn't have to go through first-run. I think it's desirable to keep this behavior so as to not surprise developers."
There's at least 2 issues here:
- The GN rule to copy chrome/app/firstRun is missing (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22&sq=package:chromium&dr=C&l=462), I'll add it.
- The GN 64 bit build has no dependency on courgette.exe but it's listed in the list of files that need to be archived here https://cs.chromium.org/chromium/src/chrome/tools/build/win/FILES.cfg?q=FILES.cf&sq=package:chromium&l=553 , I think that we don't need this anymore so the right fix is probably just to remove this from FILES.cfg ? (at least for the 32 bit build)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2a3e3abd589b619860f8a2ac181e78ca91bd1ec

commit f2a3e3abd589b619860f8a2ac181e78ca91bd1ec
Author: sebmarchand <sebmarchand@chromium.org>
Date: Tue Jul 19 01:53:18 2016

Fix the Win64 GN installer config

- Add the copy_first_run target (equivalent of https://cs.chromium.org/chromium/src/chrome/chrome_exe.gypi?q=%22First+run%22&sq=package:chromium&dr=C&l=462)
- Remove courgette.exe from the official Win64 archives as we're using courgette64.exe

BUG= 628056 

Review-Url: https://codereview.chromium.org/2152333002
Cr-Commit-Position: refs/heads/master@{#406173}

[modify] https://crrev.com/f2a3e3abd589b619860f8a2ac181e78ca91bd1ec/chrome/BUILD.gn
[modify] https://crrev.com/f2a3e3abd589b619860f8a2ac181e78ca91bd1ec/courgette/BUILD.gn

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17502ed46616115c1586a0c99375c9be93441c70

commit 17502ed46616115c1586a0c99375c9be93441c70
Author: sebmarchand <sebmarchand@chromium.org>
Date: Wed Jul 20 22:33:54 2016

Fix the definition of the syzygy_optimize variable in GN

Remove the 'symbol_level==2' condition as we can assume than an official build (without fast link) will have symbols.

R=dpranke@chromium.org
BUG= 628056 

Review-Url: https://codereview.chromium.org/2167793002
Cr-Commit-Position: refs/heads/master@{#406698}

[modify] https://crrev.com/17502ed46616115c1586a0c99375c9be93441c70/build/config/compiler/compiler.gni

Comment 6 by brettw@chromium.org, Jul 25 2016

Blockedon: 631242
Status: Fixed (was: Started)
Things look to work now.

Sign in to add a comment