New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628039 link

Starred by 10 users

Issue metadata

Status: WontFix
Merged: issue 848106
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug

Blocked on: View detail
issue 668278
issue 765723



Sign in to add a comment

Gap between tab stroke and toolbar top separator at 1.5x

Project Member Reported by rpop@chromium.org, Jul 13 2016

Issue description

From ainslie: "some strokes are crisp (EV/URL separator bar, toolbar top and bottom). Some strokes are not (omnibox top and bottom). The toolbar's bottom stroke doesn't reach the edge of the window and so isn't the same width as the top stroke. There's a small gap where the tab meets the toolbar."

See https://docs.google.com/presentation/d/1UhaA_YtZ6lOqkSXyJyqnLm3sUlMGfBvwsMf0OsB_Cao/edit#slide=id.g15410670a2_0_74
 
Labels: Te-NeedsFurtherTriage
Components: UI>Browser>TabStrip
Labels: -Pri-3 -Te-NeedsFurtherTriage M-53 Proj-MaterialDesign-NativeUI OS-Chrome OS-Linux Pri-2
Summary: Gap between tab stroke and toolbar top separator at 1.5x (was: At 1.5X there are issues with top-chrome strokes)
Omnibox strokes are  bug 627469 .

Toolbar bottom not going to the window edge is intentional and is present regardless of scale factor.  That's called the "client edge" region.  Long term I'd probably like to get rid of it.

I wonder if the tab gap is  bug 621139 .
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 19 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Unconfirmed)

Comment 5 by bsep@chromium.org, Aug 9 2016

Labels: Hotlist-Win10FrontendPolish
Since it's a bit confusing from the discussion, this bug is focused on the teeny gap between the tab stroke and the toolbar top stroke.
tab-gap-150.PNG
17.8 KB View Download
In that screenshot, the tab's top stroke is also not on a pixel boundary like it should be.
Nor is the New Tab Button bottom stroke.
Components: UI>HighDPI

Comment 9 by bsep@chromium.org, Dec 2 2016

Blockedon: 668278
Project Member

Comment 10 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by bsep@chromium.org, Dec 11 2017

Labels: -Pri-2 -Hotlist-Recharge-Cold -M-54 -MovedFrom-53 Pri-3
Status: Available (was: Untriaged)
Still a problem, still blocked
Owner: malaykeshav@chromium.org
malaykeshav@ could you please look into this
Blockedon: 765723
This bug should not be present on Chrome since Pixel canvas has been enabled on it.
Pixel canvas should solve majority of the issues mentioned in the doc linked.

Comment 14 by bsep@chromium.org, Dec 14 2017

Cc: robliao@chromium.org pnangunoori@chromium.org susanjuniab@chromium.org
 Issue 763569  has been merged into this issue.
Mergedinto: 848106
Status: Duplicate (was: Available)
Status: Assigned (was: Duplicate)
On second thought let's dupe the other way.
Cc: tbergquist@chromium.org malaykeshav@chromium.org
 Issue 848106  has been merged into this issue.
Labels: -Proj-MaterialDesign-NativeUI -OS-Chrome Proj-MdRefresh OS-Mac
Note that this is an issue on more platforms than just Windows, so enabling pixel canvas only on Windows, even if it fixes the bug, would not be a complete answer.
The long term goal is to enable pixel canvas on all platforms. 

Also I am not sure if Mac has this issue since it only supports integral scale factors.
Labels: -OS-Mac
Yeah, fair enough.
I checked out how pixel canvas affects the issue in  crbug.com/848106 .  The top and bottom of tabs are correct at 125 and 150 (yay) but the left and right tab edges are blurry on 125 (see attached 125_pixel_zoomed.png).
125_pixel_zoomed.png
14.8 KB View Download
Owner: bettes@chromium.org
bettes: What does UX think of this issue?
Cc: ligim...@chromium.org
 Issue 859795  has been merged into this issue.
Labels: Group-New_Tab_Button
Labels: -Group-New_Tab_Button Group-Tabstrip
Status: Available (was: Assigned)
We would like to fix this
Status: WontFix (was: Available)
There are no longer strokes on tabs/toolbar in refresh.

The gap in refresh between tab and toolbar was worked around by tbergquist separately already.

Sign in to add a comment