New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628036 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

testbeds tests not inputting data into tko database

Project Member Reported by sbasi@chromium.org, Jul 13 2016

Issue description

I discovered testbed tests are failing to parse the jobs and input data into the tko database because they have multiple board labels:

Failed to retrieve board label from host labels: loopback-dongle,os%3Abrillo,board%3Adragonboard-2,board%3Adragonboard-1
Traceback (most recent call last):
  File "/usr/local/autotest/tko/parse.py", line 387, in parse_leaf_path
    mail_on_failure)
  File "/usr/local/autotest/tko/db.py", line 139, in run_with_retry
    result = function(*args, **dargs)
  File "/usr/local/autotest/tko/parse.py", line 213, in parse_one
    job = parser.make_job(path)
  File "/usr/local/autotest/tko/parsers/version_1.py", line 240, in make_job
    return job(dir)
  File "/usr/local/autotest/tko/parsers/version_0.py", line 18, in __init__
    job_dict = job.load_from_dir(dir)
  File "/usr/local/autotest/tko/parsers/version_0.py", line 33, in load_from_dir
    machine_group = cls.determine_machine_group(machine, dir)
  File "/usr/local/autotest/tko/parsers/version_0.py", line 91, in determine_machine_group
    raise BoardLabelError(error)
BoardLabelError: Failed to retrieve board label from host labels: loopback-dongle,os%3Abrillo,board%3Adragonboard-2,board%3Adragonboard-1
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/adf313165f835de2e47ad9e8d4ee9fab388e6a7c

commit adf313165f835de2e47ad9e8d4ee9fab388e6a7c
Author: Simran Basi <sbasi@google.com>
Date: Tue Jun 28 21:23:05 2016

autotest: Add suite support for testbeds.

Adds basic suite support for Android testbeds. Note this does not
support SSP and only uses the Autotest code that is currently
pushed to prod.

* Added a new provision test (provision_TestbedUpdate).
* Added a basic suite to test this workflow.
* Updated the parsers to allow for multiple boards.
* Had to adjust the provision control_segment to allow commas
  in the key-value labels.

BUG= chromium:628415 , chromium:628036 
TEST=./site_utils/run_suite.py --board=dragonboard-2 \
--build=git_mnc-brillo-dev/dragonboard-eng/3014741,\
git_mnc-brillo-dev/dragonboard-eng/3014741 \
--suite_name=dummy_testbed --pool='' --run_prod_code

Change-Id: Ica04911974d69498877b9cedb9cefc4a5d0bcdd5
Reviewed-on: https://chromium-review.googlesource.com/360663
Commit-Ready: Simran Basi <sbasi@chromium.org>
Tested-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/server/control_segments/provision
[modify] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/server/hosts/testbed.py
[add] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/test_suites/control.dummy_testbed
[modify] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/site_utils/run_suite.py
[modify] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/server/site_tests/testbed_DummyTest/control
[modify] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/server/cros/provision.py
[modify] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/tko/parsers/version_0.py
[add] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/server/site_tests/provision_TestbedUpdate/control
[add] https://crrev.com/adf313165f835de2e47ad9e8d4ee9fab388e6a7c/server/site_tests/provision_TestbedUpdate/provision_TestbedUpdate.py

Comment 2 by sbasi@chromium.org, Jul 18 2017

Status: Fixed (was: Assigned)

Sign in to add a comment