New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 628034 link

Starred by 1 user
Status: Verified
Owner:
█ ajnolley@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Android] Cursor jumps to the top left corner

Project Member Reported by yuweih@chromium.org, Jul 13 2016 
Version: ToT
OS: Android

What steps will reproduce the problem?
(1) Switch to indirect input mode
(2) Rotate the screen to landscape orientation
(3) Rotate it to portrait orientation
(4) Move the cursor a little bit

What is the expected output?

Nothing weird happens? O_o The cursor should not jump around.

What do you see instead?

After step 3 the cursor jumps to the center of the screen.
After step 4 the cursor jumps to the top-left corner of the screen.

This sounds like a repro of  issue 626460 .

Comment 1 by joedow@chromium.org, Jul 14 2016

Status: Started (was: Assigned)
This was caused by some refactoring done in M53.  I think we should merge this with the M53 release once I have landed the change in M54.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bbf9d224609df203040da6e2d3d9f7d39c2cd91

commit 1bbf9d224609df203040da6e2d3d9f7d39c2cd91
Author: joedow <joedow@chromium.org>
Date: Thu Jul 14 22:38:38 2016

Fixing a cursor position initialization problem

This issue was caused during a recent refactoring.  This CL adds the
initialization code for Trackpad mode back.

BUG= 628034 

Review-Url: https://codereview.chromium.org/2146303002
Cr-Commit-Position: refs/heads/master@{#405610}

[modify] https://crrev.com/1bbf9d224609df203040da6e2d3d9f7d39c2cd91/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/1bbf9d224609df203040da6e2d3d9f7d39c2cd91/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Comment 3 by joedow@chromium.org, Jul 15 2016

Labels: Merge-Request-53

Comment 4 by dimu@google.com, Jul 15 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 15 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/849830d4a9198614895cef5e31e1960f88271107

commit 849830d4a9198614895cef5e31e1960f88271107
Author: Joe Downing <joedow@google.com>
Date: Fri Jul 15 20:16:12 2016

Fixing a cursor position initialization problem

This issue was caused during a recent refactoring.  This CL adds the
initialization code for Trackpad mode back.

BUG= 628034 

Review-Url: https://codereview.chromium.org/2146303002
Cr-Commit-Position: refs/heads/master@{#405610}
(cherry picked from commit 1bbf9d224609df203040da6e2d3d9f7d39c2cd91)

Review URL: https://codereview.chromium.org/2151363002 .

Cr-Commit-Position: refs/branch-heads/2785@{#163}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/849830d4a9198614895cef5e31e1960f88271107/remoting/android/java/src/org/chromium/chromoting/DesktopCanvas.java
[modify] https://crrev.com/849830d4a9198614895cef5e31e1960f88271107/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Comment 6 by joedow@chromium.org, Jul 15 2016

Labels: Merge-Merged
Owner: ajnolley@chromium.org
Status: Fixed (was: Started)
This fix should be in the M53 and M54 builds.  Can you verify?  Thanks!

Comment 7 by ajnolley@chromium.org, Jul 19 2016

Status: Verified (was: Fixed)
Verified Fixed in 53.0.2785.20 and 54.0.2799.0. Following steps 1-4, the cursor no longer jumps.
►

Sign in to add a comment