New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 628031 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Android] Hold-and-press dragging doesn't quite follow the finger

Project Member Reported by yuweih@chromium.org, Jul 13 2016

Issue description

Version: ToT
OS: Android

What steps will reproduce the problem?
(1) Zoom in a little bit
(2) Switch to direct input mode
(3) hold and press on the window and drag it around

What is the expected output?

The window should move following finger finger.

What do you see instead?

Feels like the window doesn't quite follow my finger.

Maybe the viewpoint movement isn't cancelled out correctly?
 

Comment 1 by yuweih@chromium.org, Jul 14 2016

Labels: -M-52 M-54
Owner: yuweih@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a18c11e644d679175ea864c7d0d45413d226144d

commit a18c11e644d679175ea864c7d0d45413d226144d
Author: yuweih <yuweih@chromium.org>
Date: Fri Jul 22 04:33:34 2016

[Remoting Android] Fix dragging issue in direct input mode

Currently hold-and-press dragging in direct input mode doesn't quite follow
the user's finger. The problem is that when the viewport moves (since
dragging around), the cursor position will be set to the center of the
screen, while the user's finger may be on somewhere else, causing an offset
between the user's finger and the cursor position. This CL fixes this problem
by always moving the cursor to the finger's position when it's in direct
input mode and the user is dragging around.

BUG= 628031 

Review-Url: https://codereview.chromium.org/2166423003
Cr-Commit-Position: refs/heads/master@{#407060}

[modify] https://crrev.com/a18c11e644d679175ea864c7d0d45413d226144d/remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java

Comment 4 by yuweih@chromium.org, Jul 22 2016

Status: Fixed (was: Assigned)

Comment 5 by yuweih@chromium.org, Jul 27 2016

Owner: ajnolley@chromium.org
Status: Verified (was: Fixed)
Verified Fixed in 54.0.2808.0

Sign in to add a comment