No longer able to navigate to background saved pages |
||||
Issue descriptionRepro: 1. Enable the offline-pages-background-loading flag 2. Navigate to Wikipedia main page 3. Long press on a link and choose "Saved linked page for later" 4. Leave device idle for 5 minutes or so 5. Check chrome://offline-internals page and verify offline page saved 6. Put device in airplane mode 7. Select previous link (short press) and verify dino page instead of expected offline page Also note: be sure the target link doesn't have a redirect as that would be a different issue. I believe this regressed in the last week or so.
,
Jul 14 2016
Ah, looks like due to namespace change for background loading but OfflinePageTabHelper::SelectBestPageForRedirectToOffline does not accept pages with that new namespace.
,
Jul 14 2016
Discussed how to resolve with Filip - for now, will hardcode another namespace in the condition. Be nice to add some less-hard-coded policy approach later.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/847efb8039e8fd04c71c3d1426581b6f4a4f0f43 commit 847efb8039e8fd04c71c3d1426581b6f4a4f0f43 Author: dougarnett <dougarnett@chromium.org> Date: Fri Jul 15 15:46:21 2016 [Offline Pages] Allows offline redirection to offline pages with Aync Loading namespace. BUG= 628029 Review-Url: https://codereview.chromium.org/2150103002 Cr-Commit-Position: refs/heads/master@{#405760} [modify] https://crrev.com/847efb8039e8fd04c71c3d1426581b6f4a4f0f43/chrome/browser/android/offline_pages/offline_page_tab_helper.cc [modify] https://crrev.com/847efb8039e8fd04c71c3d1426581b6f4a4f0f43/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
,
Jul 15 2016
,
Aug 8 2016
Verified fixed in Chrome 54.0.2821.0 |
||||
►
Sign in to add a comment |
||||
Comment 1 by dougarnett@chromium.org
, Jul 13 2016