Add a content setting to "Always open PDFs outside Chrome" |
|||||||||||||||
Issue descriptionIf we deprecate the chrome://plugins page, Enterprise users (and perhaps some consumer users) will still need the ability to disable our internal PDF viewer and launch Adobe Acrobat.
,
Jul 13 2016
+Rachel, since this is a Desktop related change
,
Jul 19 2016
why cant that be a preference (for consumers) backed by a policy (for enterprise)? Currently location on chrome://plugins is obscure for both and is causing problems as mentioned in Issue 615738
,
Jul 19 2016
Agree completely with #3. We should also consider grandfathering in DisabledPlugins for some wildcard of "*PDF*" to also apply the new "disable internal PDF viewer" flag, so enterprises have some time to move their policies over.
,
Jul 25 2016
David, assigning to you for prioritization.
,
Jul 25 2016
Saswat is handling this item. +blumberg as well.
,
Aug 20 2016
Setting the milestone to reflect the intent to target M55.
,
Aug 22 2016
,
Aug 22 2016
Should Julian own this as well?
,
Aug 23 2016
I am fine with owning the tech side of this FR. We have mechanisms in place to also migrate "*PDF*" policies to new pref values if needed so the implementation and migration of such a policy shouldn't be too hard. I would leave Saswat as an owner for now until a decision about the priority is made.
,
Aug 23 2016
,
Aug 23 2016
Yes please prioritize this for 55. Reasoning is that it stands in the way for chrome://plugins deprecation.
,
Aug 25 2016
I will take ownership and either do it myself or find somebody to volunteer the work! :)
,
Sep 26 2016
,
Oct 5 2016
Both CLs are in review. https://codereview.chromium.org/2369353002/ https://codereview.chromium.org/2392923002/ The second one is critical to get in before the branch point because it contains some new strings.
,
Oct 5 2016
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5e6f66e96a2a91700a169cc1afa66c0da46185d commit d5e6f66e96a2a91700a169cc1afa66c0da46185d Author: pastarmovj <pastarmovj@chromium.org> Date: Wed Oct 05 16:52:17 2016 Adds a pref and a policy to decide if PDFs should always be opened externally. If set this pref disables the PDF viewer and instead download the file and automatically opens the external PDF viewer. UI for controlling the pref will be added in subsequent CL. BUG= 628014 TEST=unit_tests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2369353002 Cr-Commit-Position: refs/heads/master@{#423189} [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.h [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs_unittest.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.h [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_factory.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_unittest.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.h [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/components/policy/resources/policy_templates.json [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/tools/metrics/histograms/histograms.xml
,
Oct 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86 commit 8c7be7eaa985a8b4a29de3dda25963f4f2f12c86 Author: pastarmovj <pastarmovj@chromium.org> Date: Wed Oct 05 20:07:20 2016 Add UI for local manipulation of the PDF plugin preference. It shows the state of the pref in the content settings dialog and allows its modification if not controlled by policy in which case an idicator is present to make this visible. Known issues that will be addressed in future CLs - On about:plugins the plugin is shown as disbled by policy even if disabled by the user. - If Chrome is default app for PDFs and this setting is on a vicious loop will happen where Chrome will copy the file over and over. Downloads should not proceed to opening PDFs in this case regardless of the user's choice. BUG= 628014 TEST=automatic ui tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2392923002 Cr-Commit-Position: refs/heads/master@{#423268} [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/app/generated_resources.grd [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/resources/options/content_settings.html [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/ui/webui/options/content_settings_handler.cc [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/test/data/policy/policy_test_cases.json
,
Oct 6 2016
,
Oct 19 2016
Is it possible that you missed updating the material design UI? Your change might get lost in that case. Did you give the UI team a headsup about the new content setting?
,
Oct 20 2016
The content settings windows was not yet done in the material version. dbeam told me that when they port the content settings UI they will take into account this piece as well. But good thing that you remind me to check whether this has/will happen[ed].
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5e6f66e96a2a91700a169cc1afa66c0da46185d commit d5e6f66e96a2a91700a169cc1afa66c0da46185d Author: pastarmovj <pastarmovj@chromium.org> Date: Wed Oct 05 16:52:17 2016 Adds a pref and a policy to decide if PDFs should always be opened externally. If set this pref disables the PDF viewer and instead download the file and automatically opens the external PDF viewer. UI for controlling the pref will be added in subsequent CL. BUG= 628014 TEST=unit_tests CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2369353002 Cr-Commit-Position: refs/heads/master@{#423189} [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.h [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs_unittest.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.h [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_factory.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_unittest.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.cc [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.h [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/components/policy/resources/policy_templates.json [modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/tools/metrics/histograms/histograms.xml
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86 commit 8c7be7eaa985a8b4a29de3dda25963f4f2f12c86 Author: pastarmovj <pastarmovj@chromium.org> Date: Wed Oct 05 20:07:20 2016 Add UI for local manipulation of the PDF plugin preference. It shows the state of the pref in the content settings dialog and allows its modification if not controlled by policy in which case an idicator is present to make this visible. Known issues that will be addressed in future CLs - On about:plugins the plugin is shown as disbled by policy even if disabled by the user. - If Chrome is default app for PDFs and this setting is on a vicious loop will happen where Chrome will copy the file over and over. Downloads should not proceed to opening PDFs in this case regardless of the user's choice. BUG= 628014 TEST=automatic ui tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2392923002 Cr-Commit-Position: refs/heads/master@{#423268} [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/app/generated_resources.grd [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/resources/options/content_settings.html [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/ui/webui/options/content_settings_handler.cc [modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/test/data/policy/policy_test_cases.json
,
Nov 4 2016
[Automated comment] removing mislabelled merge-merged-2840 |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by thestig@chromium.org
, Jul 13 2016