New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 10 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug

Blocked on:
issue 653120
issue 653528

Blocking:
issue 615738



Sign in to add a comment

Add a content setting to "Always open PDFs outside Chrome"

Project Member Reported by lafo...@chromium.org, Jul 13 2016

Issue description

If we deprecate the chrome://plugins page, Enterprise users (and perhaps some consumer users) will still need the ability to disable our internal PDF viewer and launch Adobe Acrobat.

 
Components: UI>Settings
Cc: rpop@chromium.org
+Rachel, since this is a Desktop related change

Comment 3 by saswat@chromium.org, Jul 19 2016

why cant that be a preference (for consumers) backed by a policy (for enterprise)? Currently location on chrome://plugins is obscure for both and is causing problems as mentioned in  Issue 615738 

Comment 4 by wfh@chromium.org, Jul 19 2016

Agree completely with #3.

We should also consider grandfathering in DisabledPlugins for some wildcard of "*PDF*" to also apply the new "disable internal PDF viewer" flag, so enterprises have some time to move their policies over.

Comment 5 by emaxx@chromium.org, Jul 25 2016

Cc: atwilson@chromium.org
Owner: dskaram@chromium.org
Status: Assigned (was: Untriaged)
David, assigning to you for prioritization.

Comment 6 by dskaram@google.com, Jul 25 2016

Owner: saswat@chromium.org
Saswat is handling this item. +blumberg as well.
Labels: M-55
Setting the milestone to reflect the intent to target M55.

Comment 8 by dchan@google.com, Aug 22 2016

Cc: trapti@chromium.org krishna...@chromium.org monachow@chromium.org
Should Julian own this as well?
I am fine with owning the tech side of this FR.

We have mechanisms in place to also migrate "*PDF*" policies to new pref values if needed so the implementation and migration of such a policy shouldn't be too hard.

I would leave Saswat as an owner for now until a decision about the priority is made.

Comment 11 by dskaram@google.com, Aug 23 2016

Cc: -dskaram@chromium.org
Yes please prioritize this for 55. Reasoning is that it stands in the way for chrome://plugins deprecation. 
Cc: -pastarmovj@chromium.org saswat@chromium.org
Owner: pastarmovj@chromium.org
I will take ownership and either do it myself or find somebody to volunteer the work! :)
Status: Started (was: Assigned)
Both CLs are in review. 

https://codereview.chromium.org/2369353002/
https://codereview.chromium.org/2392923002/

The second one is critical to get in before the branch point because it contains some new strings.
Blockedon: 653120
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e6f66e96a2a91700a169cc1afa66c0da46185d

commit d5e6f66e96a2a91700a169cc1afa66c0da46185d
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Oct 05 16:52:17 2016

Adds a pref and a policy to decide if PDFs should always be opened externally.

If set this pref disables the PDF viewer and instead download the file and
automatically opens the external PDF viewer.

UI for controlling the pref will be added in subsequent CL.

BUG= 628014 
TEST=unit_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2369353002
Cr-Commit-Position: refs/heads/master@{#423189}

[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.h
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs_unittest.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.h
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_factory.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_unittest.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.h
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/components/policy/resources/policy_templates.json
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/tools/metrics/histograms/histograms.xml

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86

commit 8c7be7eaa985a8b4a29de3dda25963f4f2f12c86
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Oct 05 20:07:20 2016

Add UI for local manipulation of the PDF plugin preference.

It shows the state of the pref in the content settings dialog and allows
its modification if not controlled by policy in which case an idicator is
present to make this visible.

Known issues that will be addressed in future CLs

- On about:plugins the plugin is shown as disbled by policy even if disabled
  by the user.
- If Chrome is default app for PDFs and this setting is on a vicious loop
  will happen where Chrome will copy the file over and over. Downloads should
  not proceed to opening PDFs in this case regardless of the user's choice.

BUG= 628014 
TEST=automatic ui tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2392923002
Cr-Commit-Position: refs/heads/master@{#423268}

[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/app/generated_resources.grd
[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/resources/options/content_settings.html
[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/test/data/policy/policy_test_cases.json

Blockedon: 653528
Cc: msramek@chromium.org
Is it possible that you missed updating the material design UI? Your change might get lost in that case. Did you give the UI team a headsup about the new content setting?
Status: Fixed (was: Started)
The content settings windows was not yet done in the material version. 

dbeam told me that when they port the content settings UI they will take into account this piece as well. But good thing that you remind me to check whether this has/will happen[ed].

Project Member

Comment 22 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5e6f66e96a2a91700a169cc1afa66c0da46185d

commit d5e6f66e96a2a91700a169cc1afa66c0da46185d
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Oct 05 16:52:17 2016

Adds a pref and a policy to decide if PDFs should always be opened externally.

If set this pref disables the PDF viewer and instead download the file and
automatically opens the external PDF viewer.

UI for controlling the pref will be added in subsequent CL.

BUG= 628014 
TEST=unit_tests
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2369353002
Cr-Commit-Position: refs/heads/master@{#423189}

[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs.h
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/download/download_prefs_unittest.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs.h
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_factory.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/plugins/plugin_prefs_unittest.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.cc
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/common/pref_names.h
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/components/policy/resources/policy_templates.json
[modify] https://crrev.com/d5e6f66e96a2a91700a169cc1afa66c0da46185d/tools/metrics/histograms/histograms.xml

Project Member

Comment 23 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86

commit 8c7be7eaa985a8b4a29de3dda25963f4f2f12c86
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Oct 05 20:07:20 2016

Add UI for local manipulation of the PDF plugin preference.

It shows the state of the pref in the content settings dialog and allows
its modification if not controlled by policy in which case an idicator is
present to make this visible.

Known issues that will be addressed in future CLs

- On about:plugins the plugin is shown as disbled by policy even if disabled
  by the user.
- If Chrome is default app for PDFs and this setting is on a vicious loop
  will happen where Chrome will copy the file over and over. Downloads should
  not proceed to opening PDFs in this case regardless of the user's choice.

BUG= 628014 
TEST=automatic ui tests.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2392923002
Cr-Commit-Position: refs/heads/master@{#423268}

[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/app/generated_resources.grd
[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/resources/options/content_settings.html
[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/8c7be7eaa985a8b4a29de3dda25963f4f2f12c86/chrome/test/data/policy/policy_test_cases.json

Comment 24 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment