New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627984 link

Starred by 2 users
Status: Fixed
Owner:
dalecur...@chromium.org
Closed: Jul 2016
Cc:
█ w...@chromium.org
liber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Convert inline functions returning TimeDelta values to constexpr in media/

Project Member Reported by dalecur...@chromium.org, Jul 13 2016 
Convert media/base/timestamp_constants and AndroidVideoDecodeAccelerator to use constexpr. These files have inline functions returning a TimeDelta which should instead now use constexpr. Probably there are a few more of these cases too.

Comment 1 by dalecur...@chromium.org, Jul 13 2016

Cc: w...@chromium.org liber...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a7f93d67f79d6afadb0f74254eef19b5ff9318

commit 39a7f93d67f79d6afadb0f74254eef19b5ff9318
Author: dalecurtis <dalecurtis@chromium.org>
Date: Tue Jul 19 18:34:59 2016

Convert media constants to constexpr.

Replaces silly MEDIA_EXPORT inline functions with constexpr
equivalents. Fingers crossed it passes the bots!

BUG= 627984 
TEST=compiles

Review-Url: https://codereview.chromium.org/2158923004
Cr-Commit-Position: refs/heads/master@{#406326}

[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chrome/browser/media/android/remote/remote_media_player_bridge.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/balanced_media_task_runner_factory.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/buffering_controller.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/buffering_controller.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/buffering_state.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/buffering_state.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/demuxer_stream_adapter.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/base/media_task_runner.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/decoder/cast_audio_decoder_linux.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/pipeline/av_pipeline_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/chromecast/media/cma/pipeline/media_pipeline_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/content/renderer/media/android/media_source_delegate.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/content/renderer/media/android/webmediaplayer_android.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/content/renderer/media/webrtc/media_stream_remote_video_source.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/audio_decoder_job.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/demuxer_android.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_codec_decoder_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_codec_player.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_codec_player_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_decoder_job.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_decoder_job.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_player_bridge.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_source_player.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_source_player_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_statistics.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/media_statistics.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/android/video_media_codec_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_buffer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_buffer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_buffer_converter.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_buffer_queue_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_discard_helper.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_discard_helper.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_discard_helper_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_splicer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_splicer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_splicer_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_timestamp_helper.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_timestamp_helper.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/audio_timestamp_helper_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/bitstream_buffer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/decoder_buffer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/decoder_buffer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/decoder_buffer_queue.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/decoder_buffer_queue_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/demuxer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/demuxer_perftest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/fake_demuxer_stream.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/pipeline_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/seekable_buffer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/seekable_buffer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/seekable_buffer_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/stream_parser_buffer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/stream_parser_buffer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/time_delta_interpolator.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/timestamp_constants.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/base/video_frame.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/blink/buffered_data_source_host_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/blink/websourcebuffer_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/capture/video/mac/video_capture_device_avfoundation_mac.mm
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/capture/video/win/sink_input_pin_win.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/capture/video/win/video_capture_device_win.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/cdm/ppapi/external_clear_key/ffmpeg_cdm_audio_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/android/media_codec_audio_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/audio_decoder_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/audio_renderer_algorithm_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/audio_timestamp_validator.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/chunk_demuxer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/chunk_demuxer_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/decoder_stream.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/decoder_stream.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/decrypting_audio_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/decrypting_audio_decoder_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/ffmpeg_audio_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/ffmpeg_demuxer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/ffmpeg_video_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/frame_processor.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/frame_processor.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/frame_processor_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/opus_audio_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/source_buffer_range.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/source_buffer_range.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/source_buffer_stream.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/source_buffer_stream.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/source_buffer_stream_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/video_frame_stream_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/video_renderer_algorithm_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/filters/vpx_video_decoder.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_adapter_video.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_adapter_video.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_adapter_video_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_parser.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_parser_adts.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_parser_h264.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_parser_h264_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_parser_mpeg1audio.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/es_parser_test_base.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/mp2t_stream_parser.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp2t/ts_section_pes.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp4/mp4_stream_parser.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mp4/mp4_stream_parser_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/mpeg/mpeg_audio_stream_parser_base.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_cluster_parser.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_cluster_parser.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_cluster_parser_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_stream_parser.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_stream_parser_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_tracks_parser.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_tracks_parser.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/formats/webm/webm_tracks_parser_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/renderers/audio_renderer_impl.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/renderers/skcanvas_video_renderer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/renderers/skcanvas_video_renderer.h
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/renderers/skcanvas_video_renderer_unittest.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/testing/libfuzzer/fuzzers/es_parser_adts_fuzzer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/testing/libfuzzer/fuzzers/es_parser_h264_fuzzer.cc
[modify] https://crrev.com/39a7f93d67f79d6afadb0f74254eef19b5ff9318/testing/libfuzzer/fuzzers/es_parser_mpeg1audio_fuzzer.cc

Comment 3 by dalecur...@chromium.org, Jul 22 2016

Status: Fixed (was: Available)
Converted all those I found that can be converted, there are others like DecodeTimestamp which are aggregate classes that can't be converted. To convert them we'd need to remove the shell around TimeDelta.
►

Sign in to add a comment