Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bfbff851505f6314f4b0f7eaf3b22e16348f3528

commit bfbff851505f6314f4b0f7eaf3b22e16348f3528
Author: mfoltz <mfoltz@chromium.org>
Date: Thu Jul 21 17:57:44 2016

[Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute.

This API change allows the MRPM to pass a Promise to the MR that represents the
outcome of a call to terminateRoute().  The result is logged in a new histogram, MediaRouter.Provider.TerminateRoute.Result.

The change is designed to be backwards compatible with MRPM versions that do not return a Promise.

The MRPM side change will be done next.

BUG= 627967 

Review-Url: https://codereview.chromium.org/2145983003
Cr-Commit-Position: refs/heads/master@{#406897}

[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/mojo/media_router_type_converters.cc
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/chrome/browser/media/router/route_request_result.h
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/extensions/renderer/resources/media_router_bindings.js
[modify] https://crrev.com/bfbff851505f6314f4b0f7eaf3b22e16348f3528/tools/metrics/histograms/histograms.xml

MRPM side CL has landed.  Can be verified by looking at MediaRouter.Provider.TerminateRoute.Result histogram and seeing that outcomes of terminateRoute() are being recorded.

Is there any reason not to merge this into 53?

There really aren't any user visible changes.  It just adds metrics to collect the result.

We're seeing ~500 events/day being logged in M53 canary and starting to see non-OK results on 7/25 (meaning newer builds of the component are correctly sending back results).

Is it the M53 canary, or the M54 canary?  I thought M54 had already been cut, but it would be nice to get this in to M53 if possible.

I meant M54 canary.  Why do you want this in M53?

So the ghire app integration can use it as soon as possible.  It's probably not critical as it sounds like they have a work around, but if it doesn't hurt anything to have it in M53 this is a better solution for them.

Requesting merge.

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468

commit b5d3a2a9f52f0358320d2a7ee4a8ff2938222468
Author: mark a. foltz <mfoltz@chromium.org>
Date: Thu Jul 28 22:43:54 2016

[Media Router] Adds return value to mojo MediaRouteProvider::TerminateRoute.

This API change allows the MRPM to pass a Promise to the MR that represents the
outcome of a call to terminateRoute().  The result is logged in a new histogram, MediaRouter.Provider.TerminateRoute.Result.

The change is designed to be backwards compatible with MRPM versions that do not return a Promise.

The MRPM side change will be done next.

BUG= 627967 

Review-Url: https://codereview.chromium.org/2145983003
Cr-Commit-Position: refs/heads/master@{#406897}
(cherry picked from commit bfbff851505f6314f4b0f7eaf3b22e16348f3528)

Review URL: https://codereview.chromium.org/2196433002 .

Cr-Commit-Position: refs/branch-heads/2785@{#398}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/mojo/media_router_type_converters.cc
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/chrome/browser/media/router/route_request_result.h
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/extensions/renderer/resources/media_router_bindings.js
[modify] https://crrev.com/b5d3a2a9f52f0358320d2a7ee4a8ff2938222468/tools/metrics/histograms/histograms.xml