New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627953 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

wingdings font-family no longer seems to work

Reported by rkilar...@gmail.com, Jul 13 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.8 Safari/537.36

Steps to reproduce the problem:
1. Element with a particular character from wingding font
2. Style on element of font-family: wingdings
3. The element no longer shows the wingdings character, instead it shows unicode character.

What is the expected behavior?
Item should display in wingdings font should display

What went wrong?
Has wingdings been dropped from Chrome somehow?

Did this work before? Yes Stable channel still works, broken now in Dev & Beta

Chrome version: 53.0.2785.8  Channel: dev
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0
 

Comment 1 by rkilar...@gmail.com, Jul 13 2016

You can see this on this web page:

http://www.alanwood.net/demos/wingdings.html

The Windgings Character column SHOULD MATCH what's in the Unicode Character (it does in IE), but Beta and Dev Chrome no longer match.
Components: Blink>Fonts

Comment 3 by e...@chromium.org, Jul 13 2016

Cc: drott@chromium.org jsc...@chromium.org e...@chromium.org
Status: Available (was: Unconfirmed)
Interesting. For some reason we fail to load wingdings in beta.

Comment 4 by drott@chromium.org, Jul 18 2016

Cc: kojii@chromium.org behdad@chromium.org
Behdad@, kojii@, could this be a symbol CMAP format issue?

Comment 5 by e...@chromium.org, Jul 18 2016

Labels: -Type-Bug Type-Bug-Regression
Owner: kojii@chromium.org
Status: Asss (was: Available)

Comment 6 by e...@chromium.org, Jul 18 2016

Status: Assigned (was: Asss)

Comment 7 by kojii@chromium.org, Jul 19 2016

Owner: drott@chromium.org
Yes, this is a regression from hb-ot-font switch in  bug 589340 . The page renders correctly on IE and on Chrome stable, but not on beta/dev nor on Firefox, as observed in comment #15 of  bug 589340 .

We probably don't want to revert it do we? Any chance for HB to support symbol CMAP?

Comment 8 by drott@chromium.org, Jul 19 2016

Behdad, any chance this could be brought into HarfBuzz with a short timeline? Or do we need to implement a fallback callback based on CMAP table format? Thanks very much in advance if you plan to add it.

Comment 9 by behdad@google.com, Jul 19 2016

It's straightforward.  I have had wanted to do it.  Will send a patch this week.

Comment 10 by drott@chromium.org, Jul 19 2016

Great, thanks!

Comment 12 by drott@chromium.org, Jul 26 2016

Status: Fixed (was: Assigned)
Fixed by rolling HarfBuzz to 1.3.0, tracked in  issue 630275 . 

Layout test upcoming in https://codereview.chromium.org/2183023003
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b550f7d3b713058b9a719fdfd79cd863638d6327

commit b550f7d3b713058b9a719fdfd79cd863638d6327
Author: drott <drott@chromium.org>
Date: Tue Jul 26 14:53:44 2016

Add a Windows layout test for validating symbol CMAP encoding support

In version 1.3.0 HarfBuzz adds support [1] for symbol encoding
CMAP tables (platform ID = 3, encoding ID = 0, glyphs offset by
0xF000), for which support in Blink regressed when we moved to
the OpenType functions from HarfBuzz. This layout test adds a
custom SymbolCMAPTest font which uses the Microsoft specific
symbol CMAP encoding. It also adds a reference font which has the
same glyph for comparison at Private Use area codepoint 0xE000.

The test font's CMAP table for platformID="3" looks as follows,
when dumped using ttx:

    <cmap_format_4 platformID="3" platEncID="0" language="0">
      <map code="0xf020" name="space"/>
      <map code="0xf041" name="A"/>
    </cmap_format_4>

So, it was verified to follow the Symbol CMAP encoding pattern.

[1] https://github.com/behdad/harfbuzz/commit/34f9aa582c3a03b578c7eae3d2e8860a0bd5cb00

BUG= 627953 
R=behdad,kojii,eae

Review-Url: https://codereview.chromium.org/2183023003
Cr-Commit-Position: refs/heads/master@{#407794}

[modify] https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327/third_party/WebKit/LayoutTests/NeverFixTests
[add] https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327/third_party/WebKit/LayoutTests/fast/text/resources/SymbolCMAPTest.ttf
[add] https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327/third_party/WebKit/LayoutTests/fast/text/resources/SymbolCMAPTestRef.ttf
[add] https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327/third_party/WebKit/LayoutTests/fast/text/symbol-cmap-expected.html
[add] https://crrev.com/b550f7d3b713058b9a719fdfd79cd863638d6327/third_party/WebKit/LayoutTests/fast/text/symbol-cmap.html

Comment 14 by hlo@chromium.org, Sep 12 2016

Cc: josa...@chromium.org
This is something that is affecting Quickoffice Chrome. 

According to this thread: https://productforums.google.com/forum/#!topic/chrome/zlvlLoZum6Q this bug started appearing in Chrome 52 and has been fixed in Chrome 55. Should this be cherry picked into Chrome 53/54? Otherwise it will be broken for a long period of time - until Chrome 55 gets into Chrome Stable channel?


Cc: gov...@chromium.org bustamante@chromium.org
+govind@chromium.org, bustamante@chromium.org to evaluate merge question in c#14

Comment 16 Deleted

Please request a merge to M53 and M54 by adding "Merge-Request-53" and "Merge-Request-54" labels.

We already cut M53 Stable RC for this week release. We can take this change in for next M53 stable release if any in future (hopefully by then it will be baked in M54 beta too)

bustamante@ for M54 merge review and approval.

Comment 18 by hlo@chromium.org, Sep 13 2016

Labels: Merge-Request-54

Comment 19 by dimu@chromium.org, Sep 13 2016

Labels: -Merge-Request-54 Merge-Review-54 Hotlist-Merge-Review
[Automated comment] Commit may have occurred before M54 branch point (8/25/2016), needs manual review.

Comment 20 by drott@chromium.org, Sep 13 2016

It's unfortunate that this regression occurred but I am somewhat hesitant to backport https://crrev.com/e58743c4354ba98a29907e630d616da3053ccf53 to M53, the stable branch because it's not an isolated commit fixing symbol fonts, but a version roll of HarfBuzz. 

M54 already has HarfBuzz 1.3.0 which has the fix, compare 
https://chromium.googlesource.com/chromium/src/+/54.0.2840.25/third_party/harfbuzz-ng/README.chromium

Labels: -Hotlist-Merge-review -Merge-Review-54
Yeah it looks like HarfBuzz is already on 1.3.0 and the layout tests from #13 are present in the 2840 branch.

Removing Merge-Review-54 Hotlist-Merge-Review labels.  If there was a different change that needed to be merged, add the label back and I'll review again.

Sign in to add a comment