Deal with Chrome getting updated but WebAPK process not being terminated |
|||
Issue descriptionThis causes a number of issues: - The runtime library is cached. We need to re-extract the runtime library from the Chrome APK - If a user uninstall & reinstalls Chrome, the host browser uid may change. This causes issues with WebApkServiceFactory's host browser uid checking
,
Jul 20 2016
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b475d23eae38217dc460763f670e0fa150fea36e commit b475d23eae38217dc460763f670e0fa150fea36e Author: pkotwicz <pkotwicz@chromium.org> Date: Fri Jul 29 21:13:45 2016 Make HostBrowserClassLoader#getClassLoaderInstance() work if Chrome gets updated WebAPK process is not guaranteed to terminate when Chrome gets updated. The WebAPK code assumes that it is always using the latest version of runtime library. In order to guarantee this, the ClassLoader must be re-created if Chrome is updated but the WebAPK is still running. BUG= 627950 TEST=HostBrowserLauncherTest.* TBR=hanxi (TBR for DEP on testing/ by JUnit test) Review-Url: https://codereview.chromium.org/2179163002 Cr-Commit-Position: refs/heads/master@{#408751} [modify] https://crrev.com/b475d23eae38217dc460763f670e0fa150fea36e/chrome/android/webapk/shell_apk/BUILD.gn [modify] https://crrev.com/b475d23eae38217dc460763f670e0fa150fea36e/chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java [add] https://crrev.com/b475d23eae38217dc460763f670e0fa150fea36e/chrome/android/webapk/shell_apk/junit/DEPS [add] https://crrev.com/b475d23eae38217dc460763f670e0fa150fea36e/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/HostBrowserClassLoaderTest.java [modify] https://crrev.com/b475d23eae38217dc460763f670e0fa150fea36e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/DexLoader.java [modify] https://crrev.com/b475d23eae38217dc460763f670e0fa150fea36e/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/HostBrowserClassLoader.java
,
Aug 3 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pkotw...@chromium.org
, Jul 20 2016