New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627948 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug

Blocking:
issue 631771



Sign in to add a comment

Linker error building chrome_elf on windows

Project Member Reported by kulshin@chromium.org, Jul 13 2016

Issue description

OS: Windows 7 (not XP); GYP

D:\src\chromium\src>ninja -C out\debug chrome_elf
ninja: Entering directory `out\debug'
[1/1] LINK_EMBED(DLL) chrome_elf.dll
FAILED: chrome_elf.dll chrome_elf.dll.lib chrome_elf.dll.pdb
D:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x86 True chrome_elf.dll "D:\src\depot_tools\python276_bin\python.exe gy
p-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:chrome_elf.dll.lib /DLL /OUT:chrome_elf.dll @chrome_elf.dll.rsp" 2 mt.exe rc.exe "obj\chr
ome_elf\chrome_elf.chrome_elf.dll.intermediate.manifest" obj\chrome_elf\chrome_elf.chrome_elf.dll.generated.manifest
base.lib(base.logging.obj) : error LNK2019: unresolved external symbol __imp__MessageBoxW@16 referenced in function "void __cdecl logging::DisplayDebugMessageIn
Dialog(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?DisplayDebugMessageInDialog@logging@@YAXABV?$basic_st
ring@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
obj\base\allocator\allocator.lib : fatal error LNK1107: invalid or corrupt file: cannot read at 0x720
Traceback (most recent call last):
  File "gyp-win-tool", line 323, in <module>
    sys.exit(main(sys.argv[1:]))
  File "gyp-win-tool", line 29, in main
    exit_code = executor.Dispatch(args)
  File "gyp-win-tool", line 71, in Dispatch
    return getattr(self, method)(*args[1:])
  File "gyp-win-tool", line 179, in ExecLinkWithManifests
    subprocess.check_call(ldcmd + add_to_ld)
  File "D:\src\depot_tools\python276_bin\lib\subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'D:\src\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /IMPLIB:chr
ome_elf.dll.lib /DLL /OUT:chrome_elf.dll @chrome_elf.dll.rsp chrome_elf.dll.manifest.res' returned non-zero exit status 1107
ninja: build stopped: subcommand failed.
 
Ping...
Owner: penny...@chromium.org
whoa, just saw this ticket - thanks for forwarding Robert.

Ilya, is there a link to a bot or something?  Definitely not seeing a failure on the try bots.  If no bot link, I'll try to repro locally.
I've only seen it locally, but I don't know which bot (if any) builds this target.
Blocking: 631771
Status: WontFix (was: Untriaged)
Ilya,

I'm going to shut down this ticket now that we're fully on GN and no longer support GYP.  I'm not aware of any current build issues using GN.

The failure you saw above is exactly what we want to see when a bad dependency creeps into chrome_elf (pulling in user32).  We might come across this again after we fix GN (https://bugs.chromium.org/p/chromium/issues/detail?id=647315).  In the mean time, we've got automated backup sanity tests on the waterfalls watching for bad dependencies.

Sign in to add a comment