New issue
Advanced search Search tips

Issue 627939 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

local_device_environment doesn't handle exceptions appropriately in SetUp

Project Member Reported by jbudorick@chromium.org, Jul 13 2016

Issue description

see attached. We fail to start the logcat monitor on a single device & the entire run crashes. We should instead simply blacklist the device.
 
local_device_environment_exception.txt
6.0 KB View Download
Owner: bpastene@chromium.org
This seems to only happen for devices that were passed into the test_runner via '--target-devices-file'. Apparently the test runner doesn't apply any needed health checks for the devices read from that file.

I can take this since I introduced that logic.
Cc: bpastene@chromium.org
Owner: jbudorick@chromium.org
Status: Started (was: Available)
(sorry, already started working on it & neglected to update the status)
to clarify: I'm working on fixing local_device_environment, not on how DeviceUtils.HealthyDevices handles checking devices when it has a device_arg.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18fac5c4bf292cc711aee969b9a88f8d8630e861

commit 18fac5c4bf292cc711aee969b9a88f8d8630e861
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Thu Jul 14 01:24:43 2016

Roll src/third_party/catapult/ 7c71d1cba..70cc6874b (4 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7c71d1cba536..70cc6874be5a

$ git log 7c71d1cba..70cc6874b --date=short --no-merges --format='%ad %ae %s'

BUG= 627939 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2150773002
Cr-Commit-Position: refs/heads/master@{#405387}

[modify] https://crrev.com/18fac5c4bf292cc711aee969b9a88f8d8630e861/DEPS

Yeah, I was waiting on the catapult roll last week & forgot about the CL this week. Landing now.
Status: Fixed (was: Started)

Sign in to add a comment