New issue
Advanced search Search tips

Issue 627928 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 603217



Sign in to add a comment

Quick Unlock settings tests

Project Member Reported by jdufault@chromium.org, Jul 13 2016

Issue description

Labels: M-55
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d223ad3993032f0b5339187d1e6beaa86002af

commit 12d223ad3993032f0b5339187d1e6beaa86002af
Author: jdufault <jdufault@chromium.org>
Date: Fri Oct 14 18:04:33 2016

Browser tests for the quick_unlock settings pages.

BUG= 627928 
TBR=dbeam@
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2157673002
Cr-Commit-Position: refs/heads/master@{#425386}

[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/options_resources.grd
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/settings/people_page/lock_state_behavior.js
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[delete] https://crrev.com/f0958ace2dce08c20a3e30b823cdca7e5b1d157c/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/test/data/webui/settings/fake_quick_unlock_private.js
[add] https://crrev.com/12d223ad3993032f0b5339187d1e6beaa86002af/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Labels: Merge-Request-55
Merge request because the test CL also includes some fixes for bugs in settings that the tests discovered.

Comment 7 by gov...@chromium.org, Oct 14 2016

Is this change applicable to any specific OS or all OS?
Labels: OS-Chrome
Just CrOS

Comment 10 by dimu@chromium.org, Oct 15 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 11 by sheriffbot@chromium.org, Oct 19 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 20 2016

Labels: -merge-approved-55 merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb18f6521660743b0fb77438650897fa8bc8a5e2

commit eb18f6521660743b0fb77438650897fa8bc8a5e2
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Oct 20 18:33:46 2016

Browser tests for the quick_unlock settings pages.

BUG= 627928 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2157673002
Cr-Commit-Position: refs/heads/master@{#425386}
(cherry picked from commit 12d223ad3993032f0b5339187d1e6beaa86002af)

Review URL: https://codereview.chromium.org/2431093005 .

Cr-Commit-Position: refs/branch-heads/2883@{#217}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/options_resources.grd
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/lock_state_behavior.js
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[delete] https://crrev.com/6896b193ff6b20cd50b8727552c9d850ad39821a/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/test/data/webui/settings/fake_quick_unlock_private.js
[add] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Status: Fixed (was: Started)
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb18f6521660743b0fb77438650897fa8bc8a5e2

commit eb18f6521660743b0fb77438650897fa8bc8a5e2
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Oct 20 18:33:46 2016

Browser tests for the quick_unlock settings pages.

BUG= 627928 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2157673002
Cr-Commit-Position: refs/heads/master@{#425386}
(cherry picked from commit 12d223ad3993032f0b5339187d1e6beaa86002af)

Review URL: https://codereview.chromium.org/2431093005 .

Cr-Commit-Position: refs/branch-heads/2883@{#217}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/options_resources.grd
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/lock_screen.html
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/lock_state_behavior.js
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/password_prompt_dialog.js
[delete] https://crrev.com/6896b193ff6b20cd50b8727552c9d850ad39821a/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/browser/ui/webui/options/options_ui.cc
[modify] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/test/data/webui/settings/fake_quick_unlock_private.js
[add] https://crrev.com/eb18f6521660743b0fb77438650897fa8bc8a5e2/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Status: Verified (was: Fixed)

Sign in to add a comment