Clean up and maybe remove compile.py's --compiler flag |
|
Issue descriptionLong ago, we used to use clang by doing really tricky $PATH manipulation in compile.py. It was too complicated and people got it wrong, so we removed that and people now instead say is_clang=true / use_goma=true in their args.gn (see bug 332697 , in particular https://codereview.chromium.org/367133002) Since then, --compiler=clang has no effect on compile.py and --compiler=goma and --compiler=goma-clang have the same effect (they ensure that goma is started before builds and stopped after) So we should stop passing --compiler=clang, and also always pass --compiler=goma (and never goma-clang) for goma builds. There's talk about moving goma handling out of compile.py ( issue 627693 ), and if that happens compile.py wouldn't need a --compiler flag any more at all.
,
Jul 13 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/d1b091c2c6a01ca17a0f8c91d0a6e33bb9aea791 commit d1b091c2c6a01ca17a0f8c91d0a6e33bb9aea791 Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 19:31:33 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/30dad04ac94938ac4eadff2cf4fe243aa5f8606a commit 30dad04ac94938ac4eadff2cf4fe243aa5f8606a Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 19:39:32 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3f24026c9a55f730df9c8de024f8c112e3b1c21e recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds. (thakis@chromium.org) R=thakis@chromium.org BUG=none,but it's preparation for 627903 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2149743002 [modify] https://crrev.com/30dad04ac94938ac4eadff2cf4fe243aa5f8606a/infra/config/recipes.cfg
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/30dad04ac94938ac4eadff2cf4fe243aa5f8606a commit 30dad04ac94938ac4eadff2cf4fe243aa5f8606a Author: recipe-roller <recipe-roller@chromium.org> Date: Wed Jul 13 19:39:32 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3f24026c9a55f730df9c8de024f8c112e3b1c21e recipes/win: Stop explicitly disabling precompiled headers in recipes in goma builds. (thakis@chromium.org) R=thakis@chromium.org BUG=none,but it's preparation for 627903 TBR=martiniss@chromium.org,phajdan.jr@chromium.org Review-Url: https://codereview.chromium.org/2149743002 [modify] https://crrev.com/30dad04ac94938ac4eadff2cf4fe243aa5f8606a/infra/config/recipes.cfg |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Jul 13 2016