Crash on viewing warning in component extension's manifest
Reported by
rchlodni...@opera.com,
Jul 13 2016
|
||||
Issue descriptionVersion: 54 OS: Windows 7 What steps will reproduce the problem? (1) Modify manifest of bundled extension so that the manifest produces a warning . For example modify content_security_policy value in chrome/browser/resources/bookmark_manager/manifest.json to contain invalid token (2) Start browser with --show-component-extension-options switch (3) Go to chrome://extension (4) Enable "developer mode" checkbox (5) Enable "Collect errors" checkbox next to Bookmark Manager component extension (6) Restart browser and go to chrome://extensions (7) Click the "warnings" link next to BookmarkManager What is the expected output? Dialog with error line displayed. No Crash. What do you see instead? Crashes on trying to show manifest contents. It's OK to not show the manifest contents (like is the case with other files from component extensions). It should just not crash.
,
Aug 17 2016
,
Aug 17 2016
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4ae40ddcf81bddd262d56b9a7523466a4adba8f commit c4ae40ddcf81bddd262d56b9a7523466a4adba8f Author: rchlodnicki <rchlodnicki@opera.com> Date: Wed Aug 17 16:38:29 2016 Make sure there is no crash on parsing empty manifest Changes match the logic in SourceHighlighter in the same file and will result in UI showing message akin to 'No source file available'. This is fine as already the same happens for other source files in bundled extensions. BUG= 627896 Review-Url: https://codereview.chromium.org/2245143004 Cr-Commit-Position: refs/heads/master@{#412556} [modify] https://crrev.com/c4ae40ddcf81bddd262d56b9a7523466a4adba8f/extensions/browser/file_highlighter.cc [modify] https://crrev.com/c4ae40ddcf81bddd262d56b9a7523466a4adba8f/extensions/browser/file_highlighter_unittest.cc
,
Aug 17 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by asargent@chromium.org
, Jul 22 2016Status: Available (was: Untriaged)