Remove 'updating' restriction from {set,clear}LiveSeekableRange() calls |
||||||||
Issue descriptionSee spec issue https://github.com/w3c/media-source/issues/118 Hopefully, this restriction's removal will make it into MSE v1 spec. Regardless, this restriction makes it difficult for MSE users, so this bug tracks removing the restriction from Chromium.
,
Jul 13 2016
https://codereview.chromium.org/2144063002/ is in CQ to fix this. Once it lands and shows up in a Canary, I plan to request merge to M-53 so that users of this new MSE API don't have this 'updating' restriction fouling them up from the very beginning.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbebef53441200e0ce94dcd41668df78c93f568e commit dbebef53441200e0ce94dcd41668df78c93f568e Author: wolenetz <wolenetz@chromium.org> Date: Wed Jul 13 22:37:11 2016 MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() Anticipating a spec change to remove this 'updating' check to fix spec issue https://github.com/w3c/media-source/issues/118, these methods no longer throw exception if any of the SourceBuffers in sourceBuffers are currently updating. [1] https://github.com/w3c/web-platform-tests/pull/3296 BUG= 627880 , 624037 R=chcunningham@chromium.org TEST=Expected update [1, above] to upstream wpt/media-source/mediasource-liveseekable.html fails before and passes after this change (with --enable-experimental-web-platform-features in both cases, of course). Review-Url: https://codereview.chromium.org/2144063002 Cr-Commit-Position: refs/heads/master@{#405309} [modify] https://crrev.com/dbebef53441200e0ce94dcd41668df78c93f568e/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
,
Jul 13 2016
cc+=govind@ -- fyi, once #3 is verified in the next Canary, I plan to request merge to M53 (see also comment in #2).
,
Jul 13 2016
,
Jul 14 2016
Ok, please request a merge ti M50 branch 2785 once the change at #3 is well baked and verified in canary. Thank you.
,
Jul 14 2016
govind@, in c#6, I assume you meant M53 branch 2785 :) Thanks.
,
Jul 14 2016
Yeah, sorry. I meant M53 branch 2785. Thank you.
,
Jul 19 2016
I verified #3 today on Mac Canary 54.0.2800.0.
,
Jul 19 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b7e73684803bcf4adb6b47af752d1b81ad200e2 commit 9b7e73684803bcf4adb6b47af752d1b81ad200e2 Author: Matt Wolenetz <wolenetz@chromium.org> Date: Wed Jul 20 00:03:06 2016 MSE: Remove check for not 'updating' in {set,clear}LiveSeekableRange() Anticipating a spec change to remove this 'updating' check to fix spec issue https://github.com/w3c/media-source/issues/118, these methods no longer throw exception if any of the SourceBuffers in sourceBuffers are currently updating. [1] https://github.com/w3c/web-platform-tests/pull/3296 BUG= 627880 , 624037 TBR=chcunningham@chromium.org TEST=Expected update [1, above] to upstream wpt/media-source/mediasource-liveseekable.html fails before and passes after this change (with --enable-experimental-web-platform-features in both cases, of course). Review-Url: https://codereview.chromium.org/2144063002 Cr-Commit-Position: refs/heads/master@{#405309} (cherry picked from commit dbebef53441200e0ce94dcd41668df78c93f568e) Review URL: https://codereview.chromium.org/2166683002 . Cr-Commit-Position: refs/branch-heads/2785@{#230} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/9b7e73684803bcf4adb6b47af752d1b81ad200e2/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
,
Jul 20 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by wolenetz@chromium.org
, Jul 13 2016