New issue
Advanced search Search tips

Issue 627859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Check use of "Enable Exits On Suspend" flag

Project Member Reported by gambard@chromium.org, Jul 13 2016

Issue description

Check the use of the "Enable Exits On Suspend" experimental flag in Chrome on iOS. We suspect it could be used in tests.
If it is not used, remove it.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/20eefb2db233eaf6211804696b82e448750c6d10

commit 20eefb2db233eaf6211804696b82e448750c6d10
Author: gambard <gambard@google.com>
Date: Mon Jul 18 18:44:10 2016

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85d1c49c5d6dab4266c8e62a602bed5b523184ae

commit 85d1c49c5d6dab4266c8e62a602bed5b523184ae
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Jul 19 12:51:57 2016

Revert of Remove Enable Exits On Suspend flags on iOS (patchset #1 id:1 of https://codereview.chromium.org/2151553002/ )

Reason for revert:
Broke downstream tree as -[UIApplication cr_interpose_beginBackgroundTaskWithExpirationHandler:] is used.

Original issue's description:
> Remove Enable Exits On Suspend flags on iOS
>
> This CL removes the Enable Exits On Suspend flag on iOS.
>
> BUG= 627859 
>
> Committed: https://crrev.com/c8ae1453cbc9ee793144a6da2c3a41e5db2aeae2
> Cr-Commit-Position: refs/heads/master@{#406234}

TBR=rohitrao@chromium.org,lpromero@chromium.org,gambard@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 627859 

Review-Url: https://codereview.chromium.org/2162893002
Cr-Commit-Position: refs/heads/master@{#406257}

[modify] https://crrev.com/85d1c49c5d6dab4266c8e62a602bed5b523184ae/ios/chrome/app/BUILD.gn
[add] https://crrev.com/85d1c49c5d6dab4266c8e62a602bed5b523184ae/ios/chrome/app/UIApplication+ExitsOnSuspend.h
[add] https://crrev.com/85d1c49c5d6dab4266c8e62a602bed5b523184ae/ios/chrome/app/UIApplication+ExitsOnSuspend.mm
[modify] https://crrev.com/85d1c49c5d6dab4266c8e62a602bed5b523184ae/ios/chrome/ios_chrome.gyp

Status: Started (was: Fixed)
Fixing revert
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/7652b57d8ebda685e327c6a4057ca7c2e5548f55

commit 7652b57d8ebda685e327c6a4057ca7c2e5548f55
Author: gambard <gambard@google.com>
Date: Tue Jul 19 14:43:47 2016

Status: Fixed (was: Started)

Sign in to add a comment