New issue
Advanced search Search tips

Issue 627854 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.2%-4.1% regression in top_10_mobile_memory_ignition at 404130:404150

Project Member Reported by hablich@chromium.org, Jul 13 2016

Issue description

See the link to graphs below.
 
Cc: mythria@chromium.org
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jul 13 2016


===== BISECT JOB RESULTS =====
Status: completed


=== Bisection aborted ===
The bisect was aborted because The metric values for the initial "good" and "bad" revisions do not represent a clear regression.
Please contact the the team (see below) if you believe this is in error.

=== Warnings ===
The following warnings were raised by the bisect job:

 * Bisect failed to reproduce the regression with enough confidence.

===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N   Good?
chromium@404134  11595211  658139   17  good
chromium@404140  11454068  77329.4  18  bad

Bisect job ran on: win_8_perf_bisect
Bug ID: 627854

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests top_10_mobile_memory_ignition
Test Metric: memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/http___en.m.wikipedia.org_wiki_Science
Relative Change: 0.18%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_8_perf_bisect/builds/2027
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9007238313969506624


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5257259521671168

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: rmcilroy@chromium.org
Owner: jochen@chromium.org
Jochen - Mythri bisected this down to your CL "Remove constructor from remaining functions that aren't constructors" - https://codereview.chromium.org/2124183003. Do you have any idea why that CL could have caused a regression in the amount of memory used by V8?

Comment 6 by jochen@chromium.org, Jul 19 2016

the "bad" is lower, but lower is better for that metric (and according to this, the metric goes down)

The metric looks at the average, however, the peak didn't change, so it's not really a regression anyways

I guess my change could influence GC timing, so the avg might change? I'd say WontFix
Status: WontFix (was: Assigned)
This wasn't looking at the bisect in comment #4 - that bisect failed. Mythri did the bisect manually and saw the increase on the graphs.

Agreed that max didn't change though, so probably just an influence of GC timing. Let's mark wontfix.

Mythri: Did we fix the issue with avg recording zero values yet?
Not yet, will do it soon. This week or next.

Sign in to add a comment