New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627851 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

CWS says "added, theme installation infobar says "installed"

Project Member Reported by jawag@chromium.org, Jul 13 2016

Issue description

Chrome Version       : <M54 Canary>
URLs (if applicable) : N/A
Other browsers tested: N/A

What steps will reproduce the problem?
(1) Notice in Chrome Web Store, all strings related to installed apps/extensions/themes use the word "added" (to Chrome)
(2) Install a theme from the Chrome Web Store
(3) Look at the infobar that comes up at the top of the page once it's finished installing

What is the expected result?
It should be consistent with the CWS messaging and say, 'Added theme "Cute Kittens"'

What happens instead?
The string says, 'Installed theme "Cute Kittens"' (screenshot attached)

Please provide any additional information below. Attach a screenshot if
possible.


 
uwGgc1Yw77C.png
618 KB View Download

Comment 1 by est...@chromium.org, Jul 13 2016

The string noted above is easy to fix, but there are two other strings that I don't know how to update:

"Google has flagged [extension name] as malicious and installation has been prevented."

"[extension name] was installed remotely" (Title of the notification that an extension or app was disabled due to it being installed server side, requiring an explicit permission check from the user.)

Comment 2 by jawag@chromium.org, Jul 13 2016

Cc: konsto@chromium.org
Where does the second one (flagged as malicious, installation prevented) show up exactly?

I've requested that +konsto@ make the change to the third one (see crbug.com/618140).

Comment 3 by est...@chromium.org, Jul 13 2016

+rdevlin to answer #2. I couldn't find an example blacklisted extension to test. From reading the code it looks like it may only show up in the console.
Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)
Mac triage: Assigning to rdevlin.cronin@
@2, 3: The malicious extension case occurs when the user tries to install a blacklisted extension.  What do we want this one to read?

Comment 6 by jawag@chromium.org, Aug 10 2016

My understanding is that it's no longer possible for users to encounter an extension that has been blacklisted at all (therefore no way for a user to attempt to install a blacklisted extension). 

Do we know how often (if at all) that string is being displayed/triggered?

Comment 7 by est...@chromium.org, Aug 10 2016

Wouldn't it be possible for non-CWS installs? I think the answer is "seldom enough that we don't care too much about the string".

How about: "Foobar wasn't added because Google has flagged it as malicious."

Comment 8 by jawag@chromium.org, Aug 10 2016

SGTM
Cc: emilyschechter@chromium.org
+emilyschechter@ has a proposal right now for our SafeBrowsing download warnings. 

Could we use something structurally similar here? 
("flagged" in particular isn't something I've seen before).
for reference, the current string is

  Google has flagged "Foobar" as malicious and installation has been prevented.

that's where I got "flagged" from.
Owner: srahim@chromium.org
I'm probably not the right owner for this until we finalize string choices.  Over to srahim@ for that.
I'd recommend "This extension may be unsafe, so it can't be installed." to be consistent with the update we made last year to the string that appears on chrome://extensions when we disable an extension:

https://bugs.chromium.org/p/chromium/issues/detail?id=753636
That string is: "Disabled by Chrome. This extension may be unsafe."

SG, Devlin?

Owner: rdevlin....@chromium.org

Sign in to add a comment