New issue
Advanced search Search tips

Issue 627840 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Mark HTMLMediaElement UserActions as not_user_triggered when they are not user triggered

Project Member Reported by mlamouri@chromium.org, Jul 13 2016

Issue description

We have some actions from controls but some like Media.Paused are events which might or might not come from user triggered actions. It makes UserActions analysis a bit noisy.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4224693a21ceefcc4ada486d3616e0555f99b025

commit 4224693a21ceefcc4ada486d3616e0555f99b025
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Jul 26 22:33:28 2016

Clean up Media_* actions by marking them obsolete and not_user_trigerred.

As recommended in the actions.xml file, non user triggered actions
should be marked with this attribute so they can be filtered out in
tools that only show user actions.

Furthermore, the Media_* actions are mostly superseded by Media.Controls.*
so they have been marked as obsolete. Histograms can be added on a need
basis if we need to register occurrences of some events.

BUG= 627840 
R=isherman@chromium.org, liberato@chromium.org

Review-Url: https://codereview.chromium.org/2159813002
Cr-Commit-Position: refs/heads/master@{#407939}

[modify] https://crrev.com/4224693a21ceefcc4ada486d3616e0555f99b025/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/4224693a21ceefcc4ada486d3616e0555f99b025/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)

Sign in to add a comment