New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627791 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Notification deep linking only opens the start_url, not the requested URL in the notification intent

Project Member Reported by dominickn@chromium.org, Jul 13 2016

Issue description

ServiceTabLauncher needs to pass the notification URL into the web app launch intent - currently it doesn't do this and just uses the URL in the launch intent (i.e. the start_url).
 

Comment 1 by peter@chromium.org, Jul 13 2016

Cc: peter@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10048ec434da0f56f6b2c5579bdbee2fa06654d

commit e10048ec434da0f56f6b2c5579bdbee2fa06654d
Author: dominickn <dominickn@chromium.org>
Date: Thu Jul 14 23:54:06 2016

Open the notification URL (not the web app start_url) when deep-linking into standalone mode.

When deep-linking into a standalone web app from a notification, the
app's start_url is always opened and the URL that the notification wants
to open is ignored. This CL fixes the bug by injecting the notification
URL in place of the web app URL when deep-linking. We also force a
reload of the web app if it is already running to ensure that the desired
url is loaded.

Replacing the URL in this manner is correct as the notification URL is
guaranteed to live within the web app's scope for notification
deep-linking to trigger.

BUG= 627791 

Review-Url: https://codereview.chromium.org/2145833003
Cr-Commit-Position: refs/heads/master@{#405638}

[modify] https://crrev.com/e10048ec434da0f56f6b2c5579bdbee2fa06654d/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java
[modify] https://crrev.com/e10048ec434da0f56f6b2c5579bdbee2fa06654d/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

Labels: Merge-Request-52 Merge-Request-53
Requesting merge - this is a very small patch to fix a notifications deep linking bug.

Comment 4 by dimu@google.com, Jul 19 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M52, manual review required.

Comment 5 by dimu@google.com, Jul 19 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 6 by gov...@chromium.org, Jul 19 2016

Before we approve merge to M52, Could you please confirm whether this change is baked/verified in Canary and safe to merge?

Also is this change applicable to all OS or any specific OS?
The change is only for Android. It looks like it hasn't yet rolled to Canary on that platform (last updated 15th July).

All my local testing has been fine thus far, but I can wait until it appears in Canary to confirm.

Comment 8 by gov...@chromium.org, Jul 20 2016

Cc: amineer@chromium.org
Labels: OS-Android
Thank you  dominickn@.

+amineer for Android M52 approval
We pushed a new canary today, please test there and update the bug with your results.
Just tested on the new Canary push and the patch works as intended. Thanks!
Labels: -Merge-Review-52 Merge-Approved-52
Merge approved for M52 branch 2743.
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a681341f2addfd0fd3f59443fbd8a57ec651f0c2

commit a681341f2addfd0fd3f59443fbd8a57ec651f0c2
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Jul 22 03:22:37 2016

Open the notification URL (not the web app start_url) when deep-linking into standalone mode.

When deep-linking into a standalone web app from a notification, the
app's start_url is always opened and the URL that the notification wants
to open is ignored. This CL fixes the bug by injecting the notification
URL in place of the web app URL when deep-linking. We also force a
reload of the web app if it is already running to ensure that the desired
url is loaded.

Replacing the URL in this manner is correct as the notification URL is
guaranteed to live within the web app's scope for notification
deep-linking to trigger.

BUG= 627791 

Review-Url: https://codereview.chromium.org/2145833003
Cr-Commit-Position: refs/heads/master@{#405638}
(cherry picked from commit e10048ec434da0f56f6b2c5579bdbee2fa06654d)

Review URL: https://codereview.chromium.org/2172933002 .

Cr-Commit-Position: refs/branch-heads/2743@{#687}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/a681341f2addfd0fd3f59443fbd8a57ec651f0c2/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
[modify] https://crrev.com/a681341f2addfd0fd3f59443fbd8a57ec651f0c2/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

Project Member

Comment 13 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80da890de6f0a00d44376334d81c8d10bd8303ea

commit 80da890de6f0a00d44376334d81c8d10bd8303ea
Author: Dominick Ng <dominickn@chromium.org>
Date: Fri Jul 22 04:52:25 2016

Open the notification URL (not the web app start_url) when deep-linking into standalone mode.

When deep-linking into a standalone web app from a notification, the
app's start_url is always opened and the URL that the notification wants
to open is ignored. This CL fixes the bug by injecting the notification
URL in place of the web app URL when deep-linking. We also force a
reload of the web app if it is already running to ensure that the desired
url is loaded.

Replacing the URL in this manner is correct as the notification URL is
guaranteed to live within the web app's scope for notification
deep-linking to trigger.

BUG= 627791 

Review-Url: https://codereview.chromium.org/2145833003
Cr-Commit-Position: refs/heads/master@{#405638}
(cherry picked from commit e10048ec434da0f56f6b2c5579bdbee2fa06654d)

Review URL: https://codereview.chromium.org/2173643002 .

Cr-Commit-Position: refs/branch-heads/2785@{#281}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/80da890de6f0a00d44376334d81c8d10bd8303ea/chrome/android/java/src/org/chromium/chrome/browser/ChromeServiceTabLauncher.java
[modify] https://crrev.com/80da890de6f0a00d44376334d81c8d10bd8303ea/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

Status: Fixed (was: Assigned)

Sign in to add a comment