New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627740 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 585875



Sign in to add a comment

We should replace EditAction by InputType

Project Member Reported by yosin@chromium.org, Jul 13 2016

Issue description

It is redundant having both EditAction and InputType, since ultimate goal of InputType is described editing operation.

InputType is used in "beforeiput" and "input", but |EditAction| is used in Blink internal only. So, it is reasonable to replace EditiAction by InputType.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f230eff72cf97710177f62cc2734ffc05b7ba992

commit f230eff72cf97710177f62cc2734ffc05b7ba992
Author: chongz <chongz@chromium.org>
Date: Fri Jul 22 05:33:06 2016

[InputEvent] Replace |EditAction| with |InputType|

|EditAction| is used to describe editing operations in
Blink internal only, however with the introduction of
|InputEvent| we got a new type |InputType| which does the
same thing and SPECed.

Since having both is redundant, this CL removes
|EditAction| and finalized the list of possible
|InputType|.

This CL shouldn't have too much web-exposed effect (except
some trivial command mapping).

BUG= 627740 
Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/InputEvent/blink-dev/RrnitB0OElc/rirueVekCwAJ

Review-Url: https://codereview.chromium.org/2151353002
Cr-Commit-Position: refs/heads/master@{#407073}

[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-execcommand.html
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/LayoutTests/fast/events/inputevents/inputevent-keyboard.html
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/Editor.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.h
[delete] https://crrev.com/07a33c8ce604eeec637abe035908a19f1772d797/third_party/WebKit/Source/core/editing/commands/EditAction.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/EditCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/EditCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/FormatBlockCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/InsertListCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/MoveSelectionCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/RemoveFormatCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/TypingCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/UndoStep.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/UnlinkCommand.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/editing/commands/UnlinkCommand.h
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/events/InputEvent.cpp
[modify] https://crrev.com/f230eff72cf97710177f62cc2734ffc05b7ba992/third_party/WebKit/Source/core/events/InputEvent.h

Comment 2 by chongz@chromium.org, Jul 22 2016

Blocking: 585875
Labels: M-54 Hotlist-Input-Dev OS-All
Status: Fixed (was: Assigned)

Sign in to add a comment