New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

IPCChannelPosixTest.AdvancedConnected is flaky

Project Member Reported by roc...@chromium.org, Jul 13 2016

Issue description

IPCChannelPosixTest uses a named pipe for multiprocess Channel setup. The same pipe path is used for all tests, and this can lead to races where one test unlinks the path after another test has already tried (and silently failed) to create a new pipe there.

This seems to only manifest when trying to add new tests (even empty ones!) to the ipc_tests suite, so it's probably only working today because of luck.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4843d09c917b0b87c9ce31ec7315ff4d2f02da75

commit 4843d09c917b0b87c9ce31ec7315ff4d2f02da75
Author: rockot <rockot@chromium.org>
Date: Wed Jul 13 17:35:51 2016

Use unique pipe names for IPCChannelPosixTest tests

Eliminates races between IPCChannelPosixTest instances
which were all using the same named pipe path to establish
an IPC channel.

BUG= 627730 
R=amistry@chromium.org

Review-Url: https://codereview.chromium.org/2141403002
Cr-Commit-Position: refs/heads/master@{#405210}

[modify] https://crrev.com/4843d09c917b0b87c9ce31ec7315ff4d2f02da75/ipc/ipc_channel_posix_unittest.cc

Comment 2 by roc...@chromium.org, Jul 13 2016

Status: Fixed (was: Started)

Sign in to add a comment