New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627723 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Supplement should have a Member to the Supplementable object

Project Member Reported by haraken@chromium.org, Jul 13 2016

Issue description

If Supplement has a WeakMember to the corresponding Supplementable object, we can remove a bunch of LifecycleObservers (because the Supplement object can get the Supplementable object without observing the Supplementable object). We should add the WeakMember.

template<typename T>
class Supplement : public GarbageCollectedMixin {
  WeakMember<T> m_host;  // We should add this.
};


 
Summary: Supplement should have a Member to the Supplementable object (was: Supplement should have a WeakMember to the Supplementable object )
We decided to use Member instead of WeakMember. See https://codereview.chromium.org/2150443002/ for more discussion.

Comment 2 by sigbjo...@opera.com, Jan 19 2017

Status: Fixed (was: Untriaged)
Moving to fixed, https://codereview.chromium.org/2606643002/ 

Sign in to add a comment