Issue metadata
Sign in to add a comment
|
Regression: Grey highlight rendering is not proper on Bookmark bar.
Reported by
dmascare...@etouch.net,
Jul 13 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:54.0.2794.0 (Official Build)02e8e6a146a2a17dcd8950b783130d5937ce87dd-refs/heads/master@{#404734} 64 bit OS:Mac Pro (10.10.5, 11.11.4) Test url:1. chrome://bookmarks/#1 2. https://chrome.google.com/webstore/category/apps?hl=en What steps will reproduce the problem? 1. Launch chrome and navigate to test url 1. 2. Create ‘New folder’, one ‘sub-folder’ and navigate to NTP,bookmark it within the ‘sub folder’ (i.e Sub-folder as destination) 3. Navigate to test url 2,bookmark it within first ‘New folder’ and Open new NTP. 4. Click on Folder seen on bookmark and then press ‘Down’ arrow,’Right’ arrow and then ‘Left’ arrow. 5. Observe Focus highlight and then press ‘Down’ arrow. Actual: 1. Grey highlight is not seen on ‘Sub-folder’ after step 4. 2. After step 5, grey highlight is seen on ‘Chrome Web store’. Expected: 1. Grey highlight should be seen on ‘Sub-folder’ after step 4. This is regression issue, broken in ‘M 53’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/89f7b5aa70aefa623f67b4adf8964308aadc9b82..f3dd9f40653004de3cf212352b2e22a11af8bdee?pretty=fuller&n=1000 Suspecting: r401167 Good build:53.0.2774.0 Bad build:53.0.2776.0
,
Jul 18 2016
Issue still observed on MAC (10.11.5) for Google Chrome Canary Version - 54.0.2799.0
,
Jul 20 2016
Fyi, in progress: https://codereview.chromium.org/2169623002/
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1078d2565c0bc53dd9ef982d246fd9ac3dd49309 commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309 Author: spqchan <spqchan@chromium.org> Date: Fri Jul 22 03:37:26 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/1078d2565c0bc53dd9ef982d246fd9ac3dd49309/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jul 22 2016
,
Jul 23 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 25 2016
spqchan@, could you please merge this to M53 branch 2785 ASAP. Thank you.
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a86349d887b4000f625354c9d6ce396517947729 commit a86349d887b4000f625354c9d6ce396517947729 Author: spqchan <spqchan@chromium.org> Date: Mon Jul 25 17:57:48 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Review URL: https://codereview.chromium.org/2180963002 . Cr-Commit-Position: refs/branch-heads/2785@{#332} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm [modify] https://crrev.com/a86349d887b4000f625354c9d6ce396517947729/chrome/browser/ui/cocoa/gradient_button_cell.mm
,
Jul 25 2016
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/44233fd40b47ebf61fdef0f922f8b910f0e18b11 commit 44233fd40b47ebf61fdef0f922f8b910f0e18b11 Author: spqchan <spqchan@chromium.org> Date: Mon Aug 01 16:56:22 2016 [Material][Mac] Fixed Bookmark Items Highlight Issues Remove calls to setHighlighted: for MD bookmark items. Ensure that the items aren't highlighted when they are not enabled BUG= 627722 , 628187 , 628204 Review-Url: https://codereview.chromium.org/2169623002 Cr-Commit-Position: refs/heads/master@{#407032} (cherry picked from commit 1078d2565c0bc53dd9ef982d246fd9ac3dd49309) Review URL: https://codereview.chromium.org/2180963002 . Cr-Commit-Position: refs/branch-heads/2785@{#434} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_item_controller.h [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_item_controller.mm [modify] https://crrev.com/44233fd40b47ebf61fdef0f922f8b910f0e18b11/chrome/browser/ui/cocoa/download/download_shelf_controller.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 13 2016