New issue
Advanced search Search tips

Issue 627721 link

Starred by 1 user
Status: Fixed
Owner:
rsesek@chromium.org
Closed: Jul 2016
Cc:
a...@chromium.org
rsesek@chromium.org
justincohen@chromium.org
thakis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

building content_shell complains about xib files

Project Member Reported by jochen@chromium.org, Jul 13 2016 
[869/199/608] MACTOOL copy-bundle-reso...t/shell/app/English.lproj/MainMenu.xib
/* com.apple.ibtool.document.warnings */
/Volumes/SSD/Chrome/src/content/shell/app/English.lproj/MainMenu.xib:global: warning: This file is set to build for a version older than the deployment target. Functionality may be limited. [9]
[935/199/542] MACTOOL copy-bundle-reso...t/shell/app/English.lproj/HttpAuth.xib
/* com.apple.ibtool.document.warnings */
/Volumes/SSD/Chrome/src/content/shell/app/English.lproj/HttpAuth.xib:global: warning: This file is set to build for a version older than the deployment target. Functionality may be limited. [9]
[1643/9/24] MACTOOL copy-bundle-resour...pad/src/client/mac/sender/Breakpad.xib
/* com.apple.ibtool.document.warnings */
/Volumes/SSD/Chrome/src/breakpad/src/client/mac/sender/Breakpad.xib:global: warning: This file is set to build for a version older than the deployment target. Functionality may be limited. [9]

Comment 1 by thakis@chromium.org, Jul 13 2016

Cc: rsesek@chromium.org justincohen@chromium.org
Components: Build
Labels: Proj-GN-Migration
See also  bug 584320 .

I guess we need something like https://codereview.chromium.org/1688773002 for gn?

Comment 2 by rsesek@chromium.org, Jul 13 2016 

We already pass --minimum-deployment-target: https://cs.chromium.org/chromium/src/build/config/mac/rules.gni?q=compile_xibs&sq=package:chromium&dr=C&l=85

I think XIBs have a deployment target embedded in them as well.

Comment 3 by patricia...@chromium.org, Jul 14 2016

Status: Untriaged (was: Unconfirmed)

Comment 4 by rsesek@chromium.org, Jul 14 2016

Labels: -Proj-GN-Migration
This happens in GYP too.

Comment 5 by rsesek@chromium.org, Jul 14 2016

Owner: rsesek@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e72747d498e627f937335b584c357925d5c074db

commit e72747d498e627f937335b584c357925d5c074db
Author: rsesek <rsesek@chromium.org>
Date: Fri Jul 15 14:44:50 2016

[Mac] Update the deployment target to 10.9 in all the XIB files.

While Chromium's deployment target is still only set to 10.7 due to various code
issues, 10.9 is the true minimum required version.

BUG= 627721 
R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2148373003
Cr-Commit-Position: refs/heads/master@{#405755}

[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/AppMenu.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/AvatarMenuItem.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/BookmarkAllTabs.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/BookmarkBar.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/BookmarkBarFolderWindow.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/BookmarkBubble.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/BookmarkEditor.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/BookmarkNameFolder.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/CollectedCookies.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedCookies.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedDownloads.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedGeolocation.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedMIDISysEx.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedMedia.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedMixedScript.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedPlugins.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedPopups.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentBlockedSimple.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ContentProtocolHandlers.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/CookieDetailsView.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/DevicePermissionsPrompt.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/DownloadItem.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/DownloadShelf.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ExtensionInstallPrompt.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ExtensionInstallPromptNoWarnings.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ExtensionInstallPromptWebstoreData.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ExtensionInstalledBubble.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/FindBar.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/FirstRunBubble.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/FirstRunDialog.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/GlobalErrorBubble.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/HttpAuthLoginSheet.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/HungRendererDialog.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/ImportProgressDialog.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/InfoBar.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/MainMenu.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/OneClickSigninBubble.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/OneClickSigninDialog.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/Panel.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/SaveAccessoryView.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/TaskManager.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/chrome/app/nibs/Toolbar.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/content/shell/app/English.lproj/HttpAuth.xib
[modify] https://crrev.com/e72747d498e627f937335b584c357925d5c074db/content/shell/app/English.lproj/MainMenu.xib

Comment 7 by rsesek@chromium.org, Jul 18 2016

Status: Fixed (was: Started)
That should be most of them. Breakpad.xib will still generate this warning, but I don't want to bother fixing that.
►

Sign in to add a comment