New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627705 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 587995
issue 628460



Sign in to add a comment

Parameterize OnError method.

Project Member Reported by sanjoy....@samsung.com, Jul 13 2016

Issue description

This is required to support following part of the spec. "Let acceptedMethods be supportedMethods with all
identifiers removed that the user agent does not accept.
If the length of acceptedMethods is zero, then reject 
acceptPromise with a NotSupportedError."




 
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Blocking: 628460
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e542d0af7a4908ec043b86d858bb9206a1c9c7f9

commit e542d0af7a4908ec043b86d858bb9206a1c9c7f9
Author: sanjoy.pal <sanjoy.pal@samsung.com>
Date: Tue Jul 19 07:30:17 2016

Parameterize OnError method.

This change is required to support following part of the
spec. "Let acceptedMethods be supportedMethods with all
identifiers removed that the user agent does not accept.
If the length of acceptedMethods is zero, then reject
acceptPromise with a NotSupportedError."

BUG= 627705 

Review-Url: https://codereview.chromium.org/2145553002
Cr-Commit-Position: refs/heads/master@{#406227}

[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/test/data/android/payments/contact_details.js
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/test/data/android/payments/dynamic_shipping.js
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/test/data/android/payments/email.js
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/test/data/android/payments/free_shipping.js
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/test/data/android/payments/no_shipping.js
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/chrome/test/data/android/payments/phone.js
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/third_party/WebKit/Source/modules/payments/PaymentTestHelper.h
[modify] https://crrev.com/e542d0af7a4908ec043b86d858bb9206a1c9c7f9/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Labels: Merge-Request-53 M-53
Would like to merge e542d0af7a4908ec043b86d858bb9206a1c9c7f9 into M-53.

Comment 6 by dimu@google.com, Jul 21 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Status: Fixed (was: Started)
Merged. Not sure why the bug is not updated yet.
Labels: -Merge-Approved-53 Merge-Merged
Merged in https://codereview.chromium.org/2171503004/

Comment 9 by gov...@chromium.org, Jul 22 2016

Labels: -Merge-Merged merge-merged-2785
As per comment #8, this is already merged to M53 branch 2785 so applying "merge-merged-2785" label.

Sign in to add a comment