New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 627697 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 614228



Sign in to add a comment

Quick View: Add UMA

Project Member Reported by oka@chromium.org, Jul 13 2016

Issue description

- How many times launched broken by Volume Type/File Type.
- How long does it take to launch. 
 

Comment 1 by oka@chromium.org, Jul 13 2016

Labels: -Pri-2 Pri-1

Comment 2 by oka@chromium.org, Jul 13 2016

Labels: -Type-Bug Type-Feature

Comment 3 by oka@chromium.org, Jul 13 2016

Labels: -Pri-1 Pri-2
Blocking: 614228
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0160731876cbef11d9d7a7365c33656599fd45

commit 3a0160731876cbef11d9d7a7365c33656599fd45
Author: oka <oka@chromium.org>
Date: Thu Aug 04 10:16:20 2016

Add UMA for Quick View (file type and volume type).

FileBrowser.QuickView.FileType   - File type shown in Quick View.
FileBrowser.QuickView.VolumeType - Volume type where Quick View is opened.

BUG= 627697 
TEST=manually (using Linux, checked chrome://histograms.)

Review-Url: https://codereview.chromium.org/2081603003
Cr-Commit-Position: refs/heads/master@{#409755}

[modify] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
[modify] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/ui/file_manager/file_manager/foreground/js/file_tasks.js
[modify] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/ui/file_manager/file_manager/foreground/js/main_scripts.js
[modify] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/ui/file_manager/file_manager/foreground/js/quick_view_controller.js
[add] https://crrev.com/3a0160731876cbef11d9d7a7365c33656599fd45/ui/file_manager/file_manager/foreground/js/quick_view_uma.js

Comment 6 by oka@chromium.org, Aug 15 2016

Lets add latency metrics too.
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/621feebe12cd4625776cd1a9099acd1c22a176de

commit 621feebe12cd4625776cd1a9099acd1c22a176de
Author: oka <oka@chromium.org>
Date: Thu Aug 18 08:09:23 2016

Add an UMA for file types selected when Quick View is launched.

BUG= 627697 
TEST=opened a file and moved to the next with <Right> and checked chrome://histograms. Confirmed 1 FileBrowser.QuickView.FileTypeOnLaunch is exported and 2 FileBrowser.QuickView.FileType are exported.

Review-Url: https://codereview.chromium.org/2252723005
Cr-Commit-Position: refs/heads/master@{#412761}

[modify] https://crrev.com/621feebe12cd4625776cd1a9099acd1c22a176de/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/621feebe12cd4625776cd1a9099acd1c22a176de/ui/file_manager/file_manager/foreground/js/quick_view_uma.js

Comment 8 by oka@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)
Basic UMA has been added. Hence closing the issue.
Status: Verified (was: Fixed)

Sign in to add a comment