New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627696 link

Starred by 3 users
Status: Fixed
Owner:
█ oka@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
weifangsun@chromium.org
fukino@chromium.org
█ marian...@google.com
dhadd...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocking:
issue 640685



Sign in to add a comment

Quick View: Add test

Project Member Reported by oka@chromium.org, Jul 13 2016 
Please write some tests for this feature to reduce the manual workload needed by the test team

Sample tests:
1. Launching / Dismissing with keypress
2. Audio / Video / Images 
3. Unsupported file types

Review bug is https://bugs.chromium.org/p/chromium/issues/detail?id=618483.

Comment 1 by oka@chromium.org, Jul 13 2016

Labels: -Pri-2 Pri-1

Comment 2 by oka@chromium.org, Jul 13 2016

Labels: -Type-Bug Type-Feature

Comment 3 by weifangsun@chromium.org, Jul 13 2016

Blocking: 618483

Comment 4 by dhadd...@chromium.org, Jul 13 2016

Cc: dhadd...@chromium.org
Thanks for adding tests!

Comment 5 by oka@chromium.org, Aug 15 2016 

I added a test that checks Quick View opens with Space key.
https://codereview.chromium.org/2080613002/

Comment 6 by fukino@chromium.org, Sep 8 2016

Labels: -M-54 M-55

Comment 7 by oka@chromium.org, Sep 30 2016

Labels: -M-55 M-56

Comment 8 by oka@chromium.org, Sep 30 2016

Labels: -Pri-1 Pri-2

Comment 9 by weifangsun@chromium.org, Nov 15 2016

Blocking: -618483 640685

Comment 10 by satorux@chromium.org, Dec 8 2016

Labels: -m-56 M-57

Comment 11 by oka@chromium.org, Oct 4 2017

Cc: marian...@google.com
Status: Fixed (was: Assigned)
Marianne added another test.
https://chromium-review.googlesource.com/c/chromium/src/+/683715

Let me close the bug.
Please file another bug if there's a specific test need be added.

Comment 12 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 13 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
►

Sign in to add a comment