New issue
Advanced search Search tips

Issue 627693 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

separate build/scripts/slave/compile.py

Project Member Reported by tikuta@chromium.org, Jul 13 2016

Issue description

Current build/scripts/slave/compile.py does too many.
This script has three main steps
1. start goma client
2. compile
3. stop goma client and send report to log server

These mixed step sometimes generates confusing stdio.
I will separate this to different steps.

 

Comment 1 by tikuta@chromium.org, Jul 14 2016

Labels: -Restrict-View-Google

Comment 2 by tikuta@chromium.org, Jul 15 2016

I saw some scripts related to compile.py.
* build/scripts/slave/recipe_modules/chromium/api.py
* build/scripts/slave/recipe_modules/goma/api.py

In build repository, it looks that compile.py is used from other than recipe_modules/chromium/api.py.
So, I think it is better to not change behavior of compile.py if env and arg are not changed.

To separate build step, I consider to add option for compile.py like 
* goma-skip-setup
* goma-only-setup
* goma-skip-teardown
* goma-only-teardown

By adding above option, I will be able to make separated steps.
It does not look good way, though.

Or it is better to make new 3 scripts for goma_setup, compile and goma_teardown?

Comment 3 by thakis@chromium.org, Jul 15 2016

What's the motivation for this bug? compile.py is already much smaller than it used to be, maybe it's fine to leave the goma stuff in there? (And maybe just clean it up a bit, it has a few TODOs)

Comment 4 by ukai@chromium.org, Jul 19 2016

- want to eliminate duplication with goma recipe modules 
  (goma recipe modules needed for user that want to use compile.py)
- will fix https://bugs.chromium.org/p/chromium/issues/detail?id=544330 too?
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/4960aa40d85730935876ef62bcbb56b90ab273be

commit 4960aa40d85730935876ef62bcbb56b90ab273be
Author: tikuta <tikuta@chromium.org>
Date: Mon Jul 25 05:10:36 2016

Refactoring: separate build steps in real_main for compile.py

* extract goma_setup and goma_teardown from main_ninja.
* make a function get_parsed_options for options

After this CL will be committed, I will make scripts calling
function of compile.py in recipe_modules/goma to make separated build
steps.

BUG= 627693 

Review-Url: https://codereview.chromium.org/2155413003

[modify] https://crrev.com/4960aa40d85730935876ef62bcbb56b90ab273be/scripts/slave/compile.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/c61fe461bfc214f5129ec0efc1f42baad43ec028

commit c61fe461bfc214f5129ec0efc1f42baad43ec028
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Jul 25 05:28:22 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4960aa40d85730935876ef62bcbb56b90ab273be Refactoring: separate build steps in real_main for compile.py (tikuta@chromium.org)

R=tikuta@chromium.org
BUG= 627693 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2175193002

[modify] https://crrev.com/c61fe461bfc214f5129ec0efc1f42baad43ec028/infra/config/recipes.cfg

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 25 2016

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/0ec19c23ab50bd14eb2c8f06df7a5b2fc20908d1

commit 0ec19c23ab50bd14eb2c8f06df7a5b2fc20908d1
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Jul 25 09:48:44 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/198fcb08ee741b3f19f877a6dc376f776372d04b declare exit_status before try (tikuta@chromium.org)

R=tikuta@chromium.org
BUG= 627693 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2178853003

[modify] https://crrev.com/0ec19c23ab50bd14eb2c8f06df7a5b2fc20908d1/infra/config/recipes.cfg

Ping - please provide an update to your high priority bug. This bug is stale. Is it really P-1?
Status: WontFix (was: Assigned)
compile.py is removed

Sign in to add a comment