New issue
Advanced search Search tips

Issue 627682 link

Starred by 5 users
Status: Available
Owner: ----
Cc:
tkent@chromium.org
domenic@chromium.org
rbyers@chromium.org
haraken@chromium.org
yutak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 753671
issue 678150
issue 726176
issue 728515
issue 737879
Blocking:
issue 651757
issue 651946
issue 685012



Sign in to add a comment

Almost all of blink should be using EqualIgnoringASCIICase, LowerASCII, UpperASCII instead of their Unicode variants

Project Member Reported by esprehn@chromium.org, Jul 13 2016 
Blink is using unicode aware equalIgnoringCase all over the place, but should actually be using the ASCII one instead. WebKit has already switched almost all callers over to ASCII. 

This matches the specs which now clarify that we should be using ASCII case, and will be faster.

ex. equalIgnoringCase(formElement->getAttribute(methodAttr), "post")

should be using equalIgnoringASCIICase so póst shouldn't match.

I'm not sure how to file this bug, since it spans the entire codebase. It's also not clear if we should attempt to write tests for the 134 usages or just do a big migration:
https://cs.chromium.org/search/?q=equalIgnoringCase+file:webkit+-file:wtf&sq=package:chromium&type=cs

Comment 1 by rbyers@chromium.org, Jul 25 2016

Cc: tkent@chromium.org
Components: Blink>DOM
It seems like this is most likely to trip up developers via DOM APIs.  tkent: any thoughts?  Should we start by trying to fix this on a couple of the most popular DOM APIs?

Comment 2 by rbyers@chromium.org, Jul 25 2016

Owner: tkent@chromium.org

Comment 3 by tkent@chromium.org, Jul 26 2016

Labels: Hotlist-GoodFirstBug
Owner: ----
Status: Available (was: Untriaged)
They are corner cases, and I don't think they are sources of web developer pain.

IMO, we should rename equalIgnoringCase() to suspiciousEqualIgnoringCase(), should add equalIgnoringUnicodeCase() if necessary, and replace suspiciousEqualIgnoringCase() with equalIgnoringASCIICase() randomly :)

Comment 5 by esprehn@chromium.org, Aug 12 2016

Cc: domenic@chromium.org
FYI: https://html.spec.whatwg.org/#radio-button-state-(type=radio):compatibility-caseless

So the radio button group name is apparently spec'ed currently to be unicode caseless compared.

Comment 6 by esprehn@chromium.org, Aug 12 2016 

Looks like "hash name references" are too:
https://html.spec.whatwg.org/#rules-for-parsing-a-hash-name-reference

The spec in general calls unicode aware comparisons "compatibility caseless"

Comment 7 by domenic@chromium.org, Aug 12 2016 

Apparently "compatibility caseless" is some kind of weird thing, per https://www.w3.org/Bugs/Public/show_bug.cgi?id=16970#c8. So I think there's a spec bug here to change it to a different Unicode comparison.

But at least for radio buttons I'm seeing interoperable behavior (not compatibility caseless, but instead some kind of Unicode caseless comparison that matches my intuition). http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4375

Comment 8 by domenic@chromium.org, Aug 12 2016 

Oh, I misunderstood, that comment I linked to is talking about how "ASCII case insensitive" is weird. It's not talking about "compatibility caseless". So also the "SHOULD"s in my live dom viewer link are wrong too.

So basically ignore my previous comment, except perhaps the part saying that the results of http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=4376 are interoperable cross-browser.

Comment 9 by domenic@chromium.org, Aug 12 2016 

I fell down a spec rabbit hole here with regard to Unicode case comparisons. If anyone wants to follow along with that, I'll be over at https://github.com/whatwg/html/issues/1666. In the meantime I'll let this bug get back to its original purpose.

Comment 11 by dsinclair@chromium.org, Oct 4 2016

Owner: dsinclair@chromium.org
Status: Started (was: Available)

Comment 12 by dominicc@chromium.org, Oct 6 2016

Blocking: 651946

Comment 13 by dominicc@chromium.org, Oct 14 2016

Blocking: 651757

Comment 15 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/600811a56002d21032ca69e4ed4b05b87715f093

commit 600811a56002d21032ca69e4ed4b05b87715f093
Author: tkent <tkent@chromium.org>
Date: Fri Nov 18 09:42:33 2016

Reduce unnecessary usage of TextCaseSensitivity::TextCaseInsensitive.

Replace TextCaseInsensitive with TextCaseASCIIInsenstive if it looks
safe. Typically, comparison with ASCII characters should be
TextCaseASCIIInsensitive.
This replacement might fix user-visible bugs in some cases, but this CL has no
tests because we don't know whether such bugs exist, or how to reproduce such
bugs.

Also, this CL renames TextCaseInsensitive to TextCaseUnicodeInsensitive.

BUG=627682

Review-Url: https://codereview.chromium.org/2508033004
Cr-Commit-Position: refs/heads/master@{#433161}

[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/bindings/core/v8/ScriptRegexp.h
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/dom/DOMImplementation.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/fetch/FetchUtils.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/fetch/Resource.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/html/forms/EmailInputType.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/modules/filesystem/DOMFilePath.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/platform/ContentType.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/platform/mhtml/MHTMLParser.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/platform/network/HTTPParsers.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/platform/text/SegmentedString.h
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/web/WebFrameSerializerImpl.cpp
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/wtf/text/StringImpl.h
[modify] https://crrev.com/600811a56002d21032ca69e4ed4b05b87715f093/third_party/WebKit/Source/wtf/text/WTFStringTest.cpp

Comment 18 by tkent@chromium.org, Jan 16 2017

Blockedon: 678150

Comment 19 by tkent@chromium.org, Jan 25 2017

Blockedon: 685012

Comment 20 by tkent@chromium.org, Jan 25 2017

Blocking: 685012

Comment 21 by tkent@chromium.org, Jan 25 2017

Blockedon: -685012

Comment 22 by tkent@chromium.org, Apr 3 2017 

dsinclair@, are your working on this?

Comment 23 by dsinclair@chromium.org, Apr 3 2017

Status: Available (was: Started)
I was poking at it when I had time, but if it's needed for other things, feel free to take it.
Project Member

Comment 24 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d27468a832d5316884bd02f459cbf493697fd7e1

commit d27468a832d5316884bd02f459cbf493697fd7e1
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Apr 04 22:01:18 2017

Switch to equalIgnoringASCIICase throughout modules/accessibility

BUG=627682

Review-Url: https://codereview.chromium.org/2793913007
Cr-Commit-Position: refs/heads/master@{#461858}

[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXARIAGridCell.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
[modify] https://crrev.com/d27468a832d5316884bd02f459cbf493697fd7e1/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
Project Member

Comment 25 by bugdroid1@chromium.org, Apr 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599385089a2e09580b86528bad3814db9510ec1e

commit 599385089a2e09580b86528bad3814db9510ec1e
Author: tkent <tkent@chromium.org>
Date: Mon Apr 10 12:55:19 2017

Rename blink::AtomicString::Lower() to DeprecatedLower().

Lower() is confusing, and is misused frequently.

BUG=627682

Review-Url: https://codereview.chromium.org/2806263002
Cr-Commit-Position: refs/heads/master@{#463237}

[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/dom/Element.h
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/dom/custom/V0CustomElement.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/dom/custom/V0CustomElementRegistry.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/platform/network/HTTPParsers.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/platform/wtf/text/AtomicString.cpp
[modify] https://crrev.com/599385089a2e09580b86528bad3814db9510ec1e/third_party/WebKit/Source/platform/wtf/text/AtomicString.h
Project Member

Comment 26 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5

commit cba8f27f9e77c8b70fabf6538a74b78c503a0ce5
Author: tkent <tkent@chromium.org>
Date: Tue Apr 11 06:11:23 2017

Rename EqualIgnoringCase*() to DeprecatedEqualIgnoringCase*()

These functions are confusing, and are misused frequently.

BUG=627682
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2811793004
Cr-Commit-Position: refs/heads/master@{#463547}

[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/clipboard/DataTransfer.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/AttributeCollection.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/CompositorProxy.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/DOMImplementation.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/DocumentStatisticsCollector.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/SandboxFlags.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/StyleElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/frame/SmartClip.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/frame/csp/CSPSource.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/CrossOriginAttribute.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLBRElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLButtonElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLDivElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLHRElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLImageElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLLIElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLMenuItemElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLMetaElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLParagraphElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLParamElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLTableElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLTablePartElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/HTMLUListElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/LinkRelAttribute.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/TextControlElement.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/HiddenInputType.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/NumberInputType.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/StepRange.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/forms/TextInputType.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/HTMLElementStack.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/loader/FormSubmission.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/loader/HistoryItem.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResource.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/page/ContextMenuController.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/page/CustomContextMenuProvider.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/testing/InternalSettings.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/xml/XPathFunctions.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/xml/XPathStep.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/modules/webdatabase/DatabaseAuthorizer.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/fonts/AlternateFontFamily.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/fonts/FontFaceCreationParams.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/fonts/win/FontFallbackWin.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/loader/fetch/CrossOriginAccessControl.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/loader/fetch/FetchUtils.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/network/EncodedFormData.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/network/HTTPParsers.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/network/mime/MIMETypeRegistry.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/text/LocaleMac.mm
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/text/LocaleWin.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/StringBuilder.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/StringHash.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/StringImpl.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/StringView.cpp
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/StringView.h
[modify] https://crrev.com/cba8f27f9e77c8b70fabf6538a74b78c503a0ce5/third_party/WebKit/Source/platform/wtf/text/WTFString.h
Project Member

Comment 27 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b30725259fd3886adc458795222dc1ee600f88e

commit 7b30725259fd3886adc458795222dc1ee600f88e
Author: tkent <tkent@chromium.org>
Date: Tue Apr 11 06:26:47 2017

Add "Unicode" suffixes to some functions of WTF::String and WTF::StringImpl.

Add "Unicode" to:
 - String::Lower(locale)
 - String::Upper(locale)
 - StringImpl::Lower(locale)
 - StringImpl::Upper(locale)
 - StringImpl::Lower()
 - StringImpl::Upper()
in order to make them less confusing.

BUG=627682

Review-Url: https://codereview.chromium.org/2813533003
Cr-Commit-Position: refs/heads/master@{#463552}

[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/core/layout/LayoutText.cpp
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/AtomicString.cpp
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/StringImpl.h
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/StringImplTest.cpp
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/WTFString.cpp
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/WTFString.h
[modify] https://crrev.com/7b30725259fd3886adc458795222dc1ee600f88e/third_party/WebKit/Source/platform/wtf/text/WTFStringTest.cpp
Project Member

Comment 28 by bugdroid1@chromium.org, Apr 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06c1ecad600e9ac12f28d1ed1433d9d93c067a30

commit 06c1ecad600e9ac12f28d1ed1433d9d93c067a30
Author: tkent <tkent@chromium.org>
Date: Tue Apr 11 10:44:02 2017

Use ASCII-caseless matching for attribute names.

We applied Unicode-caseless matching unnecessarily.
New behavior matches to the DOM standard, Edge, Firefox, and Safari.

This CL renames EqualPossiblyIgnoringCase() and QualifedName::
MatchesPossiblyIgnoringCase() so that their names represent ASCII caseless matching.

BUG= 502301 ,627682

Review-Url: https://codereview.chromium.org/2814673002
Cr-Commit-Position: refs/heads/master@{#463595}

[modify] https://crrev.com/06c1ecad600e9ac12f28d1ed1433d9d93c067a30/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/case-expected.txt
[modify] https://crrev.com/06c1ecad600e9ac12f28d1ed1433d9d93c067a30/third_party/WebKit/Source/core/dom/AttributeCollection.h
[modify] https://crrev.com/06c1ecad600e9ac12f28d1ed1433d9d93c067a30/third_party/WebKit/Source/core/dom/Element.cpp
[modify] https://crrev.com/06c1ecad600e9ac12f28d1ed1433d9d93c067a30/third_party/WebKit/Source/core/dom/QualifiedName.h
[modify] https://crrev.com/06c1ecad600e9ac12f28d1ed1433d9d93c067a30/third_party/WebKit/Source/platform/wtf/text/WTFString.cpp
[modify] https://crrev.com/06c1ecad600e9ac12f28d1ed1433d9d93c067a30/third_party/WebKit/Source/platform/wtf/text/WTFString.h

Comment 29 by tkent@chromium.org, Apr 14 2017

Summary: Almost all of blink should be using EqualIgnoringASCIICase, LowerASCII, UpperASCII instead of their Unicode variants (was: Almost all of blink should be using equalIgnoringASCIICase instead of equalIgnoringCase)
Project Member

Comment 30 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22

commit 5b6458c1403e5cb2d24c8c29b8443ffd3a806e22
Author: tkent <tkent@chromium.org>
Date: Fri Apr 14 07:00:40 2017

Remove WTF::String::DeprecatedUpper()

Except MediaDocument.cpp, input strings are ASCII-only. So changing DeprecatedUpper()
to UpperASCII() wont't change any behavior.

As for MediaDocument, the input string is a translated text. Changing DeprecatedUpper()
to UpperUnicode(locale) might improve the result in "tr" and "lt" locale.

BUG=627682

Review-Url: https://codereview.chromium.org/2821633002
Cr-Commit-Position: refs/heads/master@{#464695}

[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/core/editing/EditingCommandTest.cpp
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/core/html/media/MediaDocument.cpp
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/core/layout/svg/SVGLayoutTreeAsText.cpp
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/platform/wtf/text/WTFString.cpp
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/platform/wtf/text/WTFString.h
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/platform/wtf/text/WTFStringTest.cpp
[modify] https://crrev.com/5b6458c1403e5cb2d24c8c29b8443ffd3a806e22/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
Project Member

Comment 31 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7466a84b6706007041fd3e5a348aa57ba550ba4

commit c7466a84b6706007041fd3e5a348aa57ba550ba4
Author: tyoshino <tyoshino@chromium.org>
Date: Tue Apr 18 05:04:18 2017

Replace DeprecatedEqualIgnoringCase with EqualIgnoringASCIICase in FetchUtils.h

BUG=627682
R=yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2821003002
Cr-Commit-Position: refs/heads/master@{#465143}

[modify] https://crrev.com/c7466a84b6706007041fd3e5a348aa57ba550ba4/third_party/WebKit/Source/platform/loader/fetch/FetchUtils.cpp
Project Member

Comment 32 by bugdroid1@chromium.org, Apr 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51c609b0adcce8dbe4fe185e85a7014af5b79a2

commit b51c609b0adcce8dbe4fe185e85a7014af5b79a2
Author: tyoshino <tyoshino@chromium.org>
Date: Thu Apr 20 12:19:20 2017

Use LowerASCII() for MIME type lowering

BUG=627682
R=yhirano@chromium.org

Review-Url: https://codereview.chromium.org/2835443002
Cr-Commit-Position: refs/heads/master@{#465978}

[modify] https://crrev.com/b51c609b0adcce8dbe4fe185e85a7014af5b79a2/third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp
Project Member

Comment 34 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4c18f4225d4a580bd6506687f9e39e42a79d32d

commit e4c18f4225d4a580bd6506687f9e39e42a79d32d
Author: tkent <tkent@chromium.org>
Date: Wed May 24 08:08:13 2017

Fix missing distribution recalc in quirks mode and Shadow DOM v0.

If a shadow tree had the following CONTENT element, and a class attribute of an
element was changed to class="&#x212a;", distribution recalc was not triggered
because selector matching in quirks mode is done with ASCII-lower strings, but
Element::ShouldInvalidateDistributionWhenAttributeChanged() incorrectly applied
Unicode fold-case.

  <content select=".&#x212a;">

This CL is a behavior change, but this doesn't add a new test because Shadow DOM
v0 will be removed, and Shadow DOM in quirks mode must be very rare.

BUG=627682

Review-Url: https://codereview.chromium.org/2902903002
Cr-Commit-Position: refs/heads/master@{#474209}

[modify] https://crrev.com/e4c18f4225d4a580bd6506687f9e39e42a79d32d/third_party/WebKit/Source/core/dom/Element.cpp
Project Member

Comment 35 by bugdroid1@chromium.org, May 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b451a789df9be84623fc114a4efe00f5e9dbb5e

commit 7b451a789df9be84623fc114a4efe00f5e9dbb5e
Author: tkent <tkent@chromium.org>
Date: Wed May 24 08:51:03 2017

DOM: Fix an incorrect result of getElementsByClassName() in quirks mode.

document.getElementsByClassName('\u212a') matched to class="k" and class="K",
and did not match to class="&#x212a;".  It should match only to class="&#x212a;".

Element::ClassNames() stores ASCII-lower class string, however
getElementsByClassName() applied FoldCase().

Also, this CL removes a unused data member of ClassCollection.

BUG= 725773 ,627682

Review-Url: https://codereview.chromium.org/2899243003
Cr-Commit-Position: refs/heads/master@{#474217}

[modify] https://crrev.com/7b451a789df9be84623fc114a4efe00f5e9dbb5e/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/getElementsByClassName-14.htm
[modify] https://crrev.com/7b451a789df9be84623fc114a4efe00f5e9dbb5e/third_party/WebKit/Source/core/dom/ClassCollection.cpp
[modify] https://crrev.com/7b451a789df9be84623fc114a4efe00f5e9dbb5e/third_party/WebKit/Source/core/dom/ClassCollection.h

Comment 36 by tkent@chromium.org, May 25 2017

Blockedon: 726176

Comment 37 by tkent@chromium.org, Jun 1 2017

Blockedon: 728515
Project Member

Comment 39 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdf3d528fce04dd95feb7775fbf582f6ba831465

commit fdf3d528fce04dd95feb7775fbf582f6ba831465
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Thu Jun 29 06:01:45 2017

Replace Deprecated case handling code in XMLHttpRequest.cpp

Bug: 627682
Change-Id: I9990c158e8fd7646a8803b6a60917684423e721d
Reviewed-on: https://chromium-review.googlesource.com/552397
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483306}
[modify] https://crrev.com/fdf3d528fce04dd95feb7775fbf582f6ba831465/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp

Comment 40 by tkent@chromium.org, Jun 29 2017

Blockedon: 737879
Project Member

Comment 41 by bugdroid1@chromium.org, Jun 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c89cfa50fc9f5f497a113158e031216a49301ed

commit 8c89cfa50fc9f5f497a113158e031216a49301ed
Author: Kent Tamura <tkent@chromium.org>
Date: Thu Jun 29 14:57:53 2017

Type attribute of <embed> and <object> should be ASCII case-insensitive.

According to RFC 7230 and RFC 7231, MIME types consist of ASCII characters and
should be handled as case-insensitive.  So Using DeprecatedLower() was
incorrect.

Bug: 627682
Change-Id: I8a3838436a7d40a0f2d62690810f28ea1991e2e2
Reviewed-on: https://chromium-review.googlesource.com/554444
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483364}
[add] https://crrev.com/8c89cfa50fc9f5f497a113158e031216a49301ed/third_party/WebKit/LayoutTests/plugins/type-case.html
[modify] https://crrev.com/8c89cfa50fc9f5f497a113158e031216a49301ed/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/8c89cfa50fc9f5f497a113158e031216a49301ed/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp

Comment 42 by tkent@chromium.org, Aug 9 2017

Blockedon: 753671
Project Member

Comment 43 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e09fdfcd5d12ccc8a9a17ca1a4a16d501b4fab45

commit e09fdfcd5d12ccc8a9a17ca1a4a16d501b4fab45
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Aug 09 08:42:23 2017

Use LowerASCII instead of DeprecatedLower for 'kind' attribute processing.

https://html.spec.whatwg.org/multipage/media.html#attr-track-kind
> The kind attribute is an enumerated attribute.

https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#enumerated-attribute
> If an enumerated attribute is specified, the attribute's value must be an
> ASCII case-insensitive match for one of the given keywords that ...

However, this CL has no behavior changes because kind's keywords don't contain 'k',
to which DeprecatedLower() converts a non-ASCII character.

Bug: 627682
Change-Id: I638229bcb27371ac29c8e63f85f5e32749aa97b5
Reviewed-on: https://chromium-review.googlesource.com/607740
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492909}
[modify] https://crrev.com/e09fdfcd5d12ccc8a9a17ca1a4a16d501b4fab45/third_party/WebKit/Source/core/html/HTMLTrackElement.cpp
Project Member

Comment 44 by bugdroid1@chromium.org, Aug 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ddd65a1a371a38b8ec64d51781a262afa88d52f

commit 0ddd65a1a371a38b8ec64d51781a262afa88d52f
Author: Kent Tamura <tkent@chromium.org>
Date: Wed Aug 09 09:55:14 2017

Unicode lowercase should not be applied to inputmode attribute.

https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#input-modalities:-the-inputmode-attribute
> The inputmode content attribute is an enumerated attribute that ...

https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#enumerated-attribute
> If an enumerated attribute is specified, the attribute's value must be an
> ASCII case-insensitive match for one of the given keywords that ...

Use LowerASCII instead of DeprecatedLower.

Bug: 627682
Change-Id: Icb0e4a4f54ebed0438a453e7dd7efc27881d1bd9
Reviewed-on: https://chromium-review.googlesource.com/607736
Commit-Queue: Kent Tamura <tkent@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492928}
[modify] https://crrev.com/0ddd65a1a371a38b8ec64d51781a262afa88d52f/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/0ddd65a1a371a38b8ec64d51781a262afa88d52f/third_party/WebKit/Source/core/editing/InputMethodController.h
[modify] https://crrev.com/0ddd65a1a371a38b8ec64d51781a262afa88d52f/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Comment 45 by hayato@chromium.org, Aug 28 2017

Components: -Blink>DOM
Project Member

Comment 46 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8de282e3105511bdebb3fe886b7bf5adcc359ff0

commit 8de282e3105511bdebb3fe886b7bf5adcc359ff0
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Oct 16 11:43:34 2017

<iframe> 'sandbox' tokens are ASCII case-insensitive

Per https://html.spec.whatwg.org/multipage/#attr-iframe-sandbox, tokens
are ASCII case-sensitive.

Bug: 627682
Change-Id: I06784fc40e5561846cd5d6073614b67a5f4e7509
Reviewed-on: https://chromium-review.googlesource.com/718209
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#509023}
[add] https://crrev.com/8de282e3105511bdebb3fe886b7bf5adcc359ff0/third_party/WebKit/LayoutTests/external/wpt/html/semantics/embedded-content/the-iframe-element/sandbox-ascii-case-insensitive.html
[modify] https://crrev.com/8de282e3105511bdebb3fe886b7bf5adcc359ff0/third_party/WebKit/Source/core/dom/SandboxFlags.cpp

Comment 47 by dsinclair@chromium.org, Oct 17 2017

Owner: ----
Project Member

Comment 48 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d09cdc602ca70d0155bf4cc7c31ee55bdaf1dc0e

commit d09cdc602ca70d0155bf4cc7c31ee55bdaf1dc0e
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Thu Dec 14 10:06:35 2017

Replace DeprecatedLower() with LowerASCII() in SchemeRegistry.cpp

Bug: 627682
Change-Id: I752828ced7052c99c03a8004b3e8cd75c50b9550
Reviewed-on: https://chromium-review.googlesource.com/824142
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524034}
[modify] https://crrev.com/d09cdc602ca70d0155bf4cc7c31ee55bdaf1dc0e/third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp
Project Member

Comment 49 by bugdroid1@chromium.org, Mar 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff3733c11da634d39cc2c50f0f4a3535ff9a01d

commit 8ff3733c11da634d39cc2c50f0f4a3535ff9a01d
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Wed Mar 28 08:34:25 2018

css: Replace call to DeprecatedEqualIgnoringCase with a non-deprecated one

Call EqualIgnoringASCIICase() instead; we are comparing to an ASCII
constant.

Bug: 627682

Change-Id: Ib7b217bd3acf023c1025ae25f55bfd9480ca7924
Reviewed-on: https://chromium-review.googlesource.com/980979
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546437}
[modify] https://crrev.com/8ff3733c11da634d39cc2c50f0f4a3535ff9a01d/third_party/WebKit/Source/core/css/AbstractPropertySetCSSStyleDeclaration.cpp

Comment 50 by foolip@chromium.org, Oct 12 

Here's a test failure in xpath which is due to this:
https://wpt.fyi/results/domxpath/002.html?sha=c09b8005b2

(Not arguing that this increases the priority of this issue.)
Project Member

Comment 51 by bugdroid1@chromium.org, Nov 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c6d2d0dda770e5cb5cabff97fb85920ddea1041

commit 7c6d2d0dda770e5cb5cabff97fb85920ddea1041
Author: Gyuyoung Kim <gyuyoung.kim@lge.com>
Date: Wed Nov 14 06:58:07 2018

CustomHandler: Replace a call to DeprecatedLower with a non-deprecated one

Call LowerASCII() instead of DeprecatedLower().Ascii() because we've been using after
converting to ASCII().

Bug: 627682
Change-Id: I93315ec3ff51da0ae62dcdd13beddffed4b369fc
Reviewed-on: https://chromium-review.googlesource.com/c/1335050
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com>
Cr-Commit-Position: refs/heads/master@{#607923}
[modify] https://crrev.com/7c6d2d0dda770e5cb5cabff97fb85920ddea1041/third_party/blink/renderer/modules/navigatorcontentutils/navigator_content_utils.cc
►

Sign in to add a comment