Directory named "foo.jpg" is handled as a JPEG file. |
||||||||
Issue descriptionVersion: ToT OS: Chrome OS What steps will reproduce the problem? (1) Open Files app, create a new directory in Downloads, give it a name "foo.jpg" What is the expected output? What do you see instead? The directory can be opened with an ARC app which accepts image files (e.g. photos), and doing so results in an error. Please use labels and text to provide additional information.
,
Jul 13 2016
Thanks for finding this out. I agree with simply filtering out directories for ARC here.
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4699a16ee722fae35760559e179c7a4f8a53b1f0 commit 4699a16ee722fae35760559e179c7a4f8a53b1f0 Author: hashimoto <hashimoto@chromium.org> Date: Wed Jul 13 08:04:42 2016 file_manager: Do not return ARC tasks if a directory is selected When the selection includes a directory, no ARC tasks should be returned. BUG= 627679 TEST=Cannot open a directory with ARC apps Review-Url: https://codereview.chromium.org/2141373002 Cr-Commit-Position: refs/heads/master@{#405075} [modify] https://crrev.com/4699a16ee722fae35760559e179c7a4f8a53b1f0/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
,
Jul 13 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4699a16ee722fae35760559e179c7a4f8a53b1f0 commit 4699a16ee722fae35760559e179c7a4f8a53b1f0 Author: hashimoto <hashimoto@chromium.org> Date: Wed Jul 13 08:04:42 2016 file_manager: Do not return ARC tasks if a directory is selected When the selection includes a directory, no ARC tasks should be returned. BUG= 627679 TEST=Cannot open a directory with ARC apps Review-Url: https://codereview.chromium.org/2141373002 Cr-Commit-Position: refs/heads/master@{#405075} [modify] https://crrev.com/4699a16ee722fae35760559e179c7a4f8a53b1f0/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
,
Jul 13 2016
Approving merge to M53. Please merge changes 24 hours after checking into ToT.
,
Jul 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0108dd709f996e6316672283f9c9e8dde350d9e commit a0108dd709f996e6316672283f9c9e8dde350d9e Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Fri Jul 15 03:39:35 2016 file_manager: Do not return ARC tasks if a directory is selected When the selection includes a directory, no ARC tasks should be returned. BUG= 627679 TEST=Cannot open a directory with ARC apps Review-Url: https://codereview.chromium.org/2141373002 Cr-Commit-Position: refs/heads/master@{#405075} (cherry picked from commit 4699a16ee722fae35760559e179c7a4f8a53b1f0) Review URL: https://codereview.chromium.org/2147493008 . Cr-Commit-Position: refs/branch-heads/2785@{#141} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/a0108dd709f996e6316672283f9c9e8dde350d9e/chrome/browser/chromeos/file_manager/arc_file_tasks.cc
,
Jul 15 2016
,
Oct 5 2016
ChromeOS build 8530.96.0 / 53.0.2785.154 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hashimoto@chromium.org
, Jul 13 2016