New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627664 link

Starred by 2 users
Status: Verified
Owner:
█ dspaid@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Prevent ARC from starting before the previous user data has been wiped

Project Member Reported by dspaid@chromium.org, Jul 13 2016 
If the user attempts to enable ARC immediately after disabling it (before the bridge has been stopped) the container will never be cleared.
Explicitly prevent ARC from starting before the last instance has stopped and wipe the user data before allowing it to start again.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe1a51e9faf942ace5613490077fefba8f592621

commit fe1a51e9faf942ace5613490077fefba8f592621
Author: dspaid <dspaid@chromium.org>
Date: Tue Jul 19 05:03:27 2016

Show error during opt-in if arc-bridge not stopped.

If a user attempts to disable and re-enable ARC in quick succession user
data from the former instance will not be cleared by the normal wipe
process because kArcEnabled is true again when the bridge is stopped.
To work around this the opt-in process will display an error if
attempting to opt-in before the previous ARC instance has shut down and
it will wipe data explicitly.

BUG= 627664 
TEST=Manually test with following steps:
Enable ARC
Disable ARC
Immediately re-enable ARC
Verify error message displayed
Verify user data directory removed
Click Try again
Verify ARC starts up appropriately

Review-Url: https://codereview.chromium.org/2145813002
Cr-Commit-Position: refs/heads/master@{#406216}

[modify] https://crrev.com/fe1a51e9faf942ace5613490077fefba8f592621/chrome/browser/chromeos/arc/arc_auth_service.cc
[modify] https://crrev.com/fe1a51e9faf942ace5613490077fefba8f592621/components/arc/user_data/arc_user_data_service.cc
[modify] https://crrev.com/fe1a51e9faf942ace5613490077fefba8f592621/components/arc/user_data/arc_user_data_service.h

Comment 2 by uekawa@chromium.org, Aug 2 2016 

should this be cherry-picked to M53 ?

Comment 3 by dspaid@chromium.org, Aug 2 2016 

I talked with Hiro and Yoshi and they both agreed that its too much of an edge case to worry about cherry-picking.

Comment 4 by elijahtaylor@chromium.org, Feb 24 2017

Status: Fixed (was: Assigned)

Comment 5 by abod...@chromium.org, Apr 5 2017

Status: Verified (was: Fixed)
Chrome OS 9433.0.0 59.0.3055.0
►

Sign in to add a comment