New issue
Advanced search Search tips

Issue 627639 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Resolve warnings and errors seen when building non-CrOS configs of 4.4

Project Member Reported by groeck@chromium.org, Jul 12 2016

Issue description

When building generic configs of our chromeos-4.4 kernel, various build warnings and errors may be seen.

Some of these are for missing upstream fixes, some from code coming in from the Android tree, some from platform patches in our own tree.

Bring in fixes for those, so that failures won't block generic testing of our kernel. It's good hygiene code wise, and doing generic testing of our kernel is good to catch unrelated issues that might bite ourselves later.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1ffc3d5273bdf0a67c58fc7c0dd799397f12fc17

commit 1ffc3d5273bdf0a67c58fc7c0dd799397f12fc17
Author: Guenter Roeck <groeck@chromium.org>
Date: Sat Jul 09 02:49:48 2016

CHROMEOS: platform: cros_ec: Mark suspend and resume functions as __maybe_unused

If CONFIG_PM_SLEEP is not enabled, builds may fail with the following
error.

drivers/platform/chrome/cros_ec_dev.c:500:12: error:
	'ec_device_suspend' defined but not used
drivers/platform/chrome/cros_ec_dev.c:509:12: error:
	'ec_device_resume' defined but not used

BUG= chromium:627639 
TEST=Build with CONFIG_PM_SLEEP disabled

Change-Id: I3dd78e3977b215d0f3aa1cb028c6ae725dcee033
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/360551
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/1ffc3d5273bdf0a67c58fc7c0dd799397f12fc17/drivers/platform/chrome/cros_ec_dev.c

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/69bf4da620459450411cef18e2998d1ccdc43b81

commit 69bf4da620459450411cef18e2998d1ccdc43b81
Author: Guenter Roeck <groeck@chromium.org>
Date: Tue Aug 16 22:49:31 2016

FIXUP: CHROMIUM: sched: Support for extracting EAS energy costs from DT

When allocating memory, it is desirable to check if it was actually
allocated. Also, avoid memory leaks by releasing allocated but unassigned
memory on errors.

BUG= chromium:627639 
TEST=None

Change-Id: I1196018aa873089cfe8624b441a9fb8de5dd6b0c
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/371521
Reviewed-by: Derek Basehore <dbasehore@chromium.org>

[modify] https://crrev.com/69bf4da620459450411cef18e2998d1ccdc43b81/kernel/sched/energy.c

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f23d1e1dcaaaa46ca1d474f38569d86617175028

commit f23d1e1dcaaaa46ca1d474f38569d86617175028
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Sep 07 19:07:01 2016

CHROMIUM: dm: Fix section mismatches

dm code reports lots of section mismatches such as

WARNING: init/built-in.o(.text.unlikely+0x829):
	Section mismatch in reference from the function dm_parse_args()
	to the function .init.text:dm_setup_cleanup()

dm_parse_args() is always called from functions marked as __init, so mark
it __init as well.

BUG= chromium:627639 
TEST=Build image with DM enabled and observe section mismatch output

Change-Id: Ifa2979a7fe6cbf6a47a1381ffd6c8e2cdddd9b37
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/382231
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/f23d1e1dcaaaa46ca1d474f38569d86617175028/init/do_mounts_dm.c

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/73d730871844d13fee37d337d6ebe9dd13ee09fc

commit 73d730871844d13fee37d337d6ebe9dd13ee09fc
Author: Guenter Roeck <groeck@chromium.org>
Date: Wed Sep 07 23:14:15 2016

FIXUP: CHROMIUM: alt-syscall: override getpriority syscall for Android

Export sys_getpriority to fix the following build error.

ERROR: "sys_getpriority" [security/chromiumos/alt-syscall.ko] undefined!

The problem is seen if ALT_SYSCALL_CHROMIUMOS is built as module.

BUG= chromium:627639 
TEST=Build arm64:allmodconfig

Change-Id: I8052cbe41f8b85bdee82ef2dbb33c6614cfda7af
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/382591
Reviewed-by: Chinyue Chen <chinyue@chromium.org>

[modify] https://crrev.com/73d730871844d13fee37d337d6ebe9dd13ee09fc/kernel/sys.c

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/8ca51c4e3c6cc25ad9864e112371638e6e5aeb42

commit 8ca51c4e3c6cc25ad9864e112371638e6e5aeb42
Author: Guenter Roeck <groeck@chromium.org>
Date: Mon Sep 26 21:44:08 2016

CHROMIUM: drm/evdi: Fix build error due to bad indentation

0day reports:

drivers/gpu/drm/evdi/evdi_modeset.c: In function 'evdi_crtc_cursor_move':
drivers/gpu/drm/evdi/evdi_modeset.c:242:2: error:
	this 'if' clause does not guard...

BUG= chromium:627639 
TEST=Build with -Werror=misleading-indentation

Change-Id: Ibe0df9cb3aea351e69945b98c20c3cd2e2476070
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/389771
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/8ca51c4e3c6cc25ad9864e112371638e6e5aeb42/drivers/gpu/drm/evdi/evdi_modeset.c

Comment 6 by groeck@chromium.org, Oct 17 2016

Status: Fixed (was: Started)
Currently no pending build failures. Will open new bugs as failures are seen.

Sign in to add a comment