New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627637 link

Starred by 2 users
Status: Fixed
Owner:
█ brettw@chromium.org
Last visit 26 days ago
Closed: Aug 2016
Cc:
█ brettw@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 623661



Sign in to add a comment

Convert relevant GN source sets to static libraries

Project Member Reported by brettw@chromium.org, Jul 12 2016 
One cause of the slowdown in issue 623661 is that static libraries strip code earlier in the link cycle than source_sets.

Binaries that depend on large portions of the build but don't depend on it means this earlier stripping makes a big performance impact. This is especially the case for test binaries in Chrome.

So we should try to make libraries that aren't required to be source sets static libraries in the GN build.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7761761113c883a0e49856b1dc79bbc3eae707a9

commit 7761761113c883a0e49856b1dc79bbc3eae707a9
Author: brettw <brettw@chromium.org>
Date: Wed Jul 13 22:40:06 2016

Convert test_support source sets to static libs

This changes about 1/4 of the targets in the build with the name "test_support" in the name to be static libraries instead of source sets.

Also changes related source sets to static libraries in the same files when such a change looked possible.

Also puts //components/drive:test_support_chromeos in a chromeos conditional since this target is chromeos specific).

BUG= 627637 

Review-Url: https://codereview.chromium.org/2143253002
Cr-Commit-Position: refs/heads/master@{#405312}

[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/ash/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/base/test/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/chrome/app/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/chrome/browser/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/chrome/renderer/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/chrome/test/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/autofill/content/renderer/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/browser_sync/browser/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/bubble/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/captive_portal/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/cast_certificate/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/component_updater/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/data_reduction_proxy/core/common/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/dom_distiller/core/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/drive/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/gcm_driver/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/gcm_driver/crypto/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/gcm_driver/instance_id/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/guest_view/browser/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/leveldb_proto/BUILD.gn
[modify] https://crrev.com/7761761113c883a0e49856b1dc79bbc3eae707a9/components/metrics/BUILD.gn

Comment 2 by dpranke@chromium.org, Jul 14 2016

Cc: brettw@chromium.org
Do we have any mechanism for measuring improvements here, either in build time or memory usage or both? Measuring across platforms would be particularly interesting.

Comment 3 by brettw@chromium.org, Jul 14 2016 

I'm not stressing about metrics right now. I'm just converting stuff that can obviously be converted. The performance depends on the network of dependencies, so the improvement of converting something to a static lib might not be measurable until something that depends on it is also converted (otherwise it will be brought in either way).
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dbbe5b0ad99bb678a15952dd993532f152ef97c

commit 2dbbe5b0ad99bb678a15952dd993532f152ef97c
Author: brettw <brettw@chromium.org>
Date: Thu Jul 14 19:38:57 2016

Convert some GN test support targets to static libs.

Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant.

Update the definition of //crypto:test_support to mark it testonly and make the conditions append sources rather than subtract them in the reverse condition.

A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support").

BUG= 627637 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2151653003
Cr-Commit-Position: refs/heads/master@{#405544}

[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/cc/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/open_from_clipboard/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/os_crypt/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/policy/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/pref_registry/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/prefs/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/printing/test/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/proximity_auth/cryptauth/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/safe_json/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/scheduler/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/search_engines/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/sessions/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/signin/core/browser/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/storage_monitor/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/subresource_filter/core/browser/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/sync_driver/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/sync_sessions/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/syncable_prefs/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/toolbar/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/update_client/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/user_prefs/tracked/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/webdata_services/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/components/zoom/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/content/test/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/crypto/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/dbus/BUILD.gn
[modify] https://crrev.com/2dbbe5b0ad99bb678a15952dd993532f152ef97c/device/usb/BUILD.gn
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3871f52649ace10c7c36e0b4a5042cde88e5997a

commit 3871f52649ace10c7c36e0b4a5042cde88e5997a
Author: brettw <brettw@chromium.org>
Date: Thu Jul 14 22:08:34 2016

Convert some GN test support targets to static libs.

Converts some source sets that were source sets into static libraries. Converts additional targets in the touched files to static libraries where it seemed relevant.

A few redundant dependencies were removed (one shouldn't need to specify both "foo" and "foo:test_support"). A few empty source sets were converted to groups.

BUG= 627637 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2151013002
Cr-Commit-Position: refs/heads/master@{#405593}

[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/extensions/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/google_apis/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/gpu/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ipc/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/media/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/media/audio/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/media/base/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/mojo/edk/test/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/mojo/public/cpp/test_support/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/net/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ppapi/proxy/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ppapi/shared_impl/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/remoting/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/remoting/client/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/remoting/host/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/remoting/protocol/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/remoting/signaling/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/remoting/test/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/services/shell/background/tests/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/services/shell/public/cpp/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/services/ui/public/cpp/tests/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/services/ui/ws/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/sql/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/accessibility/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/app_list/presenter/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/aura/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/base/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/compositor/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/display/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/events/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/gfx/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/gl/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/message_center/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/views/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/views/controls/webview/BUILD.gn
[modify] https://crrev.com/3871f52649ace10c7c36e0b4a5042cde88e5997a/ui/views/mus/BUILD.gn
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73

commit eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
Author: brettw <brettw@chromium.org>
Date: Thu Jul 14 23:08:37 2016

Make webkit_modules a split static library in non-component builds.

Previously this was force to a source set because it was too large for official Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows builds so it can be a static library now.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2145253003
Cr-Commit-Position: refs/heads/master@{#405618}

[modify] https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73/third_party/WebKit/Source/modules/BUILD.gn
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23302cf2b607bcfa33f7b93860e69d5a49a47635

commit 23302cf2b607bcfa33f7b93860e69d5a49a47635
Author: brettw <brettw@chromium.org>
Date: Fri Jul 15 00:54:12 2016

Convert third_party source sets to static libraries.

This covers the third_party code checked directly into Chrome.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2152033002
Cr-Commit-Position: refs/heads/master@{#405651}

[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/base/third_party/libevent/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/base/third_party/symbolize/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/base/third_party/xdg_mime/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/base/third_party/xdg_user_dirs/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/chrome/third_party/mozilla_security_manager/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/boringssl/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/ced/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/cld_2/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/dom_distiller_js/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/fips181/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/hunspell/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/iccjpeg/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/libXNVCtrl/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/libjingle/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/libsecret/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/libwebm/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/libwebp/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/mesa/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/modp_b64/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/opus/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/ots/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/protobuf/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/qcms/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/smhasher/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/wayland/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/woff2/BUILD.gn
[modify] https://crrev.com/23302cf2b607bcfa33f7b93860e69d5a49a47635/third_party/yasm/BUILD.gn
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52116563313f1ebe1e2b966b429d217442e3362b

commit 52116563313f1ebe1e2b966b429d217442e3362b
Author: henrika <henrika@chromium.org>
Date: Fri Jul 15 08:38:58 2016

Revert of Make webkit_modules a split static library in non-component builds. (patchset #2 id:20001 of https://codereview.chromium.org/2145253003/ )

Reason for revert:
I suspect that this change can cause failure in the generate_build_files step on Windows.

Making a speculative revert to see if the issue is resolved.

See also:

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Win/builds/8974/steps/generate_build_files/logs/stdio

Original issue's description:
> Make webkit_modules a split static library in non-component builds.
>
> Previously this was force to a source set because it was too large for official Windows builds to handle as a static library.
>
> This uses the split_static_library template for non-component official Windows builds so it can be a static library now.
>
> BUG= 627637 
>
> Committed: https://crrev.com/eb0a50c30fdf3d7ca8f978fb55f363cf1f702b73
> Cr-Commit-Position: refs/heads/master@{#405618}

TBR=brucedawson@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 627637 

Review-Url: https://codereview.chromium.org/2150003004
Cr-Commit-Position: refs/heads/master@{#405726}

[modify] https://crrev.com/52116563313f1ebe1e2b966b429d217442e3362b/third_party/WebKit/Source/modules/BUILD.gn
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/251c55188818138cba319ca20d843b30c71d3137

commit 251c55188818138cba319ca20d843b30c71d3137
Author: brettw <brettw@chromium.org>
Date: Fri Jul 15 18:21:26 2016

Make webkit_modules a split static library in non-component builds.

Previously this was forced to a source set because it was too large for official Windows builds to handle as a static library.

This uses the split_static_library template for non-component official Windows builds so it can be a static library now.

Updates the split_static_library template to handle the case where an output name is specified.

BUG= 627637 
Previously landed version of http://crrev.com/2145253003 with addition of split_static_library change.

Review-Url: https://codereview.chromium.org/2145753007
Cr-Commit-Position: refs/heads/master@{#405797}

[modify] https://crrev.com/251c55188818138cba319ca20d843b30c71d3137/build/split_static_library.gni
[modify] https://crrev.com/251c55188818138cba319ca20d843b30c71d3137/third_party/WebKit/Source/modules/BUILD.gn
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7c28a2362ba69d28f1aef09afc8018692be5cad

commit e7c28a2362ba69d28f1aef09afc8018692be5cad
Author: brettw <brettw@chromium.org>
Date: Wed Jul 20 22:29:38 2016

Roll openmax_dl deps.

One change:
  57d33be Convert GN source_set to static_library.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2165063002
Cr-Commit-Position: refs/heads/master@{#406695}

[modify] https://crrev.com/e7c28a2362ba69d28f1aef09afc8018692be5cad/DEPS
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc1df5ef085c4a60dca0bb908dc70c06dbc19225

commit dc1df5ef085c4a60dca0bb908dc70c06dbc19225
Author: brettw <brettw@chromium.org>
Date: Thu Jul 21 16:49:41 2016

Roll libyuv deps.

Changes:
  e84dcb4 Convert libyuv to a static library in GN.
  e497bc8 Revert "roll chromium same as webrtc jun9"
  6126968 Revert "Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)"
  81d6597 Roll chromium_revision 7fa6701bc5..1a73d11e65 (398458:399420)
  a817c15 roll chromium same as webrtc jun9
  6508580 roll chromium from 1:48 to 2:59 may 24 revision.

TBR=fbarchard
BUG= 627637 

Review-Url: https://codereview.chromium.org/2163313003
Cr-Commit-Position: refs/heads/master@{#406874}

[modify] https://crrev.com/dc1df5ef085c4a60dca0bb908dc70c06dbc19225/DEPS
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a0584f605c66b8624c506f2f4fb865b885c2d4

commit 59a0584f605c66b8624c506f2f4fb865b885c2d4
Author: brettw <brettw@chromium.org>
Date: Thu Jul 21 22:44:54 2016

Convert some component source sets to static library

This is hoping to achieve better build performance.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2161363005
Cr-Commit-Position: refs/heads/master@{#406975}

[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/dom_distiller/core/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/drive/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/error_page/renderer/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/favicon/content/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/favicon/core/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/favicon_base/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/feedback/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/filesystem/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/flags_ui/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/gcm_driver/crypto/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/guest_view/renderer/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/image_fetcher/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/invalidation/impl/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/json_schema/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/language_usage_metrics/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/leveldb/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/leveldb/public/cpp/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/memory_coordinator/browser/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/memory_coordinator/child/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/memory_coordinator/common/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/memory_pressure/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/metrics/BUILD.gn
[modify] https://crrev.com/59a0584f605c66b8624c506f2f4fb865b885c2d4/components/metrics_services_manager/BUILD.gn
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e664a26c70ff038d56a9a22afef9d0b82b8dd81d

commit e664a26c70ff038d56a9a22afef9d0b82b8dd81d
Author: brettw <brettw@chromium.org>
Date: Thu Jul 21 23:48:36 2016

Convert some component source sets to static library

This is hoping to achieve better build performance.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2173443003
Cr-Commit-Position: refs/heads/master@{#406996}

[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/nacl/browser/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/nacl/common/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/nacl/renderer/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/nacl/renderer/plugin/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/navigation_interception/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/navigation_metrics/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/net_log/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/network_hints/common/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/network_hints/renderer/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/network_session_configurator/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/ntp_tiles/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/offline_pages/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/omnibox/browser/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/password_manager/content/browser/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/password_manager/content/public/cpp/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/password_manager/core/browser/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/password_manager/core/common/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/password_manager/sync/browser/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/precache/content/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/precache/core/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/printing/browser/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/printing/common/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/printing/renderer/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/proximity_auth/ble/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/proximity_auth/logging/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/rappor/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/rlz/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/safe_json/utility/BUILD.gn
[modify] https://crrev.com/e664a26c70ff038d56a9a22afef9d0b82b8dd81d/components/search/BUILD.gn
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79f7b784a97cbb22f11064a05b621b0def87eab3

commit 79f7b784a97cbb22f11064a05b621b0def87eab3
Author: dpranke <dpranke@chromium.org>
Date: Fri Jul 22 00:55:34 2016

Fix //components/drive:drive_chromeos to only be defined on CrOS in GN.

TBR=brettw@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG= 627637 

Review-Url: https://codereview.chromium.org/2176433002
Cr-Commit-Position: refs/heads/master@{#407004}

[modify] https://crrev.com/79f7b784a97cbb22f11064a05b621b0def87eab3/components/drive/BUILD.gn
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8deee3907ceb2dd0439fb6d2be9b3f07d6968579

commit 8deee3907ceb2dd0439fb6d2be9b3f07d6968579
Author: brettw <brettw@chromium.org>
Date: Fri Jul 22 03:55:52 2016

Convert some component source sets to static library

This is hoping to achieve better build performance.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2165183003
Cr-Commit-Position: refs/heads/master@{#407052}

[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/about_handler/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/auto_login_parser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/autofill/core/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/base32/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/bookmarks/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/bookmarks/managed/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/browser_sync/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/browser_sync/common/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/cdm/common/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/certificate_transparency/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/client_update_protocol/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/constrained_window/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/content_settings/content/common/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/content_settings/core/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/cookie_config/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/crash/content/app/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/crash/content/tools/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/crash/core/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/crx_file/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/data_reduction_proxy/content/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/data_reduction_proxy/core/browser/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/data_reduction_proxy/core/common/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/data_usage/core/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/data_use_measurement/content/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/data_use_measurement/core/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/devtools_discovery/BUILD.gn
[modify] https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579/components/devtools_http_handler/BUILD.gn
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60ac558a35b6a6d297e32409a3fd48f176221a6d

commit 60ac558a35b6a6d297e32409a3fd48f176221a6d
Author: brettw <brettw@chromium.org>
Date: Fri Jul 22 17:23:54 2016

Convert some component source sets to static library

This is hoping to achieve better build performance.

BUG= 627637 

Review-Url: https://codereview.chromium.org/2170813003
Cr-Commit-Position: refs/heads/master@{#407188}

[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/search_provider_logos/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/security_state/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/signin/core/account_id/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/signin/core/common/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/ssl_config/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/ssl_errors/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/startup_metric_utils/browser/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/subresource_filter/content/browser/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/subresource_filter/content/common/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/subresource_filter/content/renderer/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/subresource_filter/core/common/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/suggestions/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/supervised_user_error_page/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/sync_bookmarks/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/translate/content/browser/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/translate/core/browser/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/translate/core/common/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/translate/core/language_detection/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/upload_list/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/url_formatter/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/variations/net/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/variations/service/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/version_info/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/version_ui/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/visitedlink/browser/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/visitedlink/common/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/visitedlink/renderer/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/web_cache/browser/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/web_cache/renderer/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/webcrypto/BUILD.gn
[modify] https://crrev.com/60ac558a35b6a6d297e32409a3fd48f176221a6d/components/wifi/BUILD.gn

Comment 17 by brettw@chromium.org, Aug 12 2016

Status: Fixed (was: Started)
I'm going to call this work done.
►

Sign in to add a comment