New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627633 link

Starred by 2 users
Status: Fixed
Owner:
█ mikec...@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Cc:
█ samu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Convert ChromeDriver Android bot to recipes

Project Member Reported by gmanikpure@chromium.org, Jul 12 2016 
First build that failed :-https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/28883

Latest build that failed :-
https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/28894

Traceback (most recent call last):
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/run.py", line 413, in run
    recipe_result = recipe_script.run(api, api._engine.properties)
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 57, in run
    self.RunSteps, properties, self.PROPERTIES, api=api)
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 521, in invoke_with_properties
    **additional_args)
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/loader.py", line 482, in _invoke_with_properties
    return callable_obj(*props, **additional_args)
  File "/b/build/scripts/slave/recipes/chromedriver.py", line 72, in RunSteps
    api.properties['got_revision_cp'])
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_modules/properties/api.py", line 26, in __getitem__
    return self._properties[key]
  File "/b/build/scripts/slave/.recipe_deps/recipe_engine/recipe_engine/types.py", line 66, in __getitem__
    return self._d[key]
KeyError: 'got_revision_cp'

Comment 1 by samu...@chromium.org, Jul 13 2016

Owner: mikec...@chromium.org
Status: Available (was: Untriaged)
Mike, any ideas what's going on?
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/fb976b8c2421ef73a6d1ab491717c018cb6a9ab2

commit fb976b8c2421ef73a6d1ab491717c018cb6a9ab2
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 21:38:04 2016
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/637c372ac5f78ce37a6718422e1ab1aa5d479663

commit 637c372ac5f78ce37a6718422e1ab1aa5d479663
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 21:59:09 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/03e8c3547c28bc7a5f171dafc479c67a00fddd65 Drop GCM (ianh@google.com)
  https://crrev.com/f4a95a732a6549cbf8a17f098c197ac16fdb71f6 Add new environment variable to unbreak builds. (ngeoffray@google.com)
  https://crrev.com/216e1a70fb807ef26a931b63ec988c27237bb546 Fix how revision_cp is obtained in chromedriver recipe. (mikecase@chromium.org)

R=mikecase@chromium.org,ngeoffray@google.com,martiniss@chromium.org,ianh@google.com
BUG= 627633 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2151673002

[modify] https://crrev.com/637c372ac5f78ce37a6718422e1ab1aa5d479663/infra/config/recipes.cfg

Comment 5 by gmanikpure@chromium.org, Jul 14 2016 

Thanks for the fix, Mike! 
Original issue is no longer seen. But now all the tests are failing with below error :-

/usr/bin/xvfb-run: 184: /usr/bin/xvfb-run: run_py_tests.py: not found

/usr/bin/xvfb-run: 184: /usr/bin/xvfb-run: run_java_tests.py: not found

https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/28952

Could you please take a look?

Comment 6 by samu...@chromium.org, Jul 15 2016 

The problem here is that the recipe is passing --build-type to the test script, which is not a recognized option. I don't think this is needed; the full path (including out/Debug) to the chromedriver binary is already passed using the --chromedriver switch, so we might be able to just remove this. If it is needed somehow by a subprocess of the test script, then we should set the BUILDTYPE environment variable.

Comment 7 by samu...@chromium.org, Jul 18 2016

Status: Assigned (was: Available)
Mike, do you know how to specify the build type as an environment variable (or if it's even needed)? This is the current failure that I'm seeing:

Usage: run_py_tests.py [options]
run_py_tests.py: error: no such option: --build-type
step returned non-zero exit code: 2
@@@STEP_FAILURE@@@

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_ChromeDriver_Tests__dbg_%2F29068%2F%2B%2Frecipes%2Fsteps%2Fpython_tests_chrome_beta_%2F0%2Fstdout

Comment 8 by mikec...@chromium.org, Jul 18 2016

Status: Started (was: Assigned)

Comment 9 by mikec...@chromium.org, Jul 18 2016 

Im unsure whether build type needs to be specified. The only place I see that it might be needed it to be passed to devil_chromium.initialize(output_dir) so that all the dependencies can be found.

Going to try removing it. If there are some errors like "forwarder not found" then we will have to find a way to add it back. There could also be some other error that comes up that Im just not seeing.
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/e5ad31e506abf607dce876b8cd6bb77e41659a05

commit e5ad31e506abf607dce876b8cd6bb77e41659a05
Author: mikecase <mikecase@chromium.org>
Date: Mon Jul 18 20:05:19 2016

Remove build-type arg from Chromedriver tests.

This isn't a valid arg for the Chromedriver test scripts and
doesn't appear to be needed. Removing usage of --build-type

BUG= 627633 

Review-Url: https://codereview.chromium.org/2154383002

[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipe_modules/chromedriver/api.py
[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json
[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json
[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json
[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_test_failure.json
[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
[modify] https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/66f1e210e8e9e1533e61fa3bfbbbd7fcd1f038c9

commit 66f1e210e8e9e1533e61fa3bfbbbd7fcd1f038c9
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Jul 18 20:08:02 2016
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8eb0a322cbb51d63110fd55569418d0e2a5fcdb5

commit 8eb0a322cbb51d63110fd55569418d0e2a5fcdb5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Mon Jul 18 20:29:10 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e5ad31e506abf607dce876b8cd6bb77e41659a05 Remove build-type arg from Chromedriver tests. (mikecase@chromium.org)

R=mikecase@chromium.org
BUG= 627633 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2154393002

[modify] https://crrev.com/8eb0a322cbb51d63110fd55569418d0e2a5fcdb5/infra/config/recipes.cfg

Comment 13 by stip@chromium.org, Jul 18 2016 

https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/29069/steps/python_tests%28chrome_beta%29/logs/stdio


======================================================================
ERROR: testDeviceManagement (__main__.ChromeDriverAndroidTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/b/build/slave/Android_ChromeDriver_Tests__dbg_/build/src/chrome/test/chromedriver/test/run_py_tests.py", line 1371, in testDeviceManagement
    for _ in device_utils.DeviceUtils.HealthyDevices()]
  File "/b/build/slave/Android_ChromeDriver_Tests__dbg_/build/src/chrome/test/chromedriver/test/run_py_tests.py", line 224, in CreateDriver
    **kwargs)
  File "/b/build/slave/Android_ChromeDriver_Tests__dbg_/build/src/chrome/test/chromedriver/test/../client/chromedriver.py", line 151, in __init__
    response = self._ExecuteCommand(Command.NEW_SESSION, params)
  File "/b/build/slave/Android_ChromeDriver_Tests__dbg_/build/src/chrome/test/chromedriver/test/../client/chromedriver.py", line 189, in _ExecuteCommand
    raise _ExceptionForResponse(response)
UnknownError: unknown error: com.chrome.beta is not installed on device 038529b2003bfd93
  (Driver info: chromedriver=2.22.400715 (68148300f639039d54fb49c314f1064e5c47c2e6),platform=Linux 3.13.0-86-generic x86_64)

Comment 14 by samu...@chromium.org, Jul 18 2016 

I've just gone and installed the beta and stable apks on this device, so this error should go away soon.

Comment 15 by gmanikpure@chromium.org, Jul 19 2016 

Errors com.chrome.beta is not installed on device 038529b2003bfd93 & com.android.chrome is not installed on device 038529b2003bfd93 are still seen.

https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/29112

We would also need to add selenium java tests:-

"/b/build/slave/Android_ChromeDriver_Tests__dbg_/build/src/chrome/test/chromedriver/third_party/java_tests" is empty or it doesn't exist. Need to map https://chromium.googlesource.com/chromium/deps/webdriver to chrome/test/chromedriver/third_party/java_tests in .gclient.
Alternatively, do:
  $ cd chrome/test/chromedriver/third_party
  $ git clone https://chromium.googlesource.com/chromium/deps/webdriver java_tests
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

Comment 16 by mikec...@chromium.org, Jul 19 2016 

Im trying to figure out how to pull in the selenium java tests via gclient
https://codereview.chromium.org/2166443002/

Also, I saw a problem where it said chrome_public is not a valid --android-package for one of the tests. I think we just have to change chrome_public to chromium but I have to double check.

Comment 17 by samu...@chromium.org, Jul 19 2016 

I'm not sure about how to do the gclient settings. But yes it's "chromium" not "chrome_public".
Project Member

Comment 19 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/a6e27b578394ec34312ccd963d7191b1b1fa2893

commit a6e27b578394ec34312ccd963d7191b1b1fa2893
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 19 18:58:16 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/4ea6215bfc3a0c742a18bf4e9a7de37e86ea5187 Misc Chromedriver bot fixes. (mikecase@chromium.org)

R=mikecase@chromium.org
BUG= 627633 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2157203003

[modify] https://crrev.com/a6e27b578394ec34312ccd963d7191b1b1fa2893/infra/config/recipes.cfg

Comment 20 by mikec...@chromium.org, Jul 19 2016 

Some more issues I see...

- Selenium java tests missing (have CL in review to set up a gclient recipe config to fix this)
- very messy recipe steps (will try to nest some steps together to clean up)
- all server logs are uploaded with same name
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ae0530827d5d5e42f713dda21226730ebdc2cecd

commit ae0530827d5d5e42f713dda21226730ebdc2cecd
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 18:18:14 2016
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ee04bcfedab1c1af7e4f9f993fbd7da6732e4a34

commit ee04bcfedab1c1af7e4f9f993fbd7da6732e4a34
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 18:36:43 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a87bcbaf42348caf72967e0cd6d76761d0245da1 Add chromedriver gclient config to pull in Selenium Java tests. (mikecase@chromium.org)

R=mikecase@chromium.org
BUG= 627633 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2166893002

[modify] https://crrev.com/ee04bcfedab1c1af7e4f9f993fbd7da6732e4a34/infra/config/recipes.cfg
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ee04bcfedab1c1af7e4f9f993fbd7da6732e4a34

commit ee04bcfedab1c1af7e4f9f993fbd7da6732e4a34
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 18:36:43 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a87bcbaf42348caf72967e0cd6d76761d0245da1 Add chromedriver gclient config to pull in Selenium Java tests. (mikecase@chromium.org)

R=mikecase@chromium.org
BUG= 627633 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2166893002

[modify] https://crrev.com/ee04bcfedab1c1af7e4f9f993fbd7da6732e4a34/infra/config/recipes.cfg

Comment 24 by stip@chromium.org, Jul 20 2016 

We have at least one green build on the new recipe: https://chromegw.corp.google.com/i/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/29152

Sam and Mike, can I get confirmation that we will stick with the recipe (and won't revert back to the old code)? If so, I can start deleting bb_run_bot.

Comment 25 by mikec...@chromium.org, Jul 20 2016 

This is Sam's decision. The bot seems to be in ok shape right now. I have 1 more CL to clean things up (https://codereview.chromium.org/2164043002)
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3e11cab002795b08e77622dd69fecddf72ee926e

commit 3e11cab002795b08e77622dd69fecddf72ee926e
Author: mikecase <mikecase@chromium.org>
Date: Wed Jul 20 23:26:04 2016

Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Adding nested steps for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG= 627633 

Review-Url: https://codereview.chromium.org/2164043002

[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/__init__.py
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/api.py
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_test_failure.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.py
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipes/chromedriver.py
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3e11cab002795b08e77622dd69fecddf72ee926e

commit 3e11cab002795b08e77622dd69fecddf72ee926e
Author: mikecase <mikecase@chromium.org>
Date: Wed Jul 20 23:26:04 2016

Clean up steps in Chromedriver recipe.

The tempfile recipe module creates a few messy looking steps and
the steps on the Chromedriver bot look very confusing and
unorganized. Adding nested steps for the test runs to clean things up.

Additionally, changed the name of server_log to make it unique for
every test run. It is currently always getting uploaded with the name
server_log and just overwriting itself.

BUG= 627633 

Review-Url: https://codereview.chromium.org/2164043002

[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/__init__.py
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/api.py
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_test_failure.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipe_modules/chromedriver/example.py
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e/scripts/slave/recipes/chromedriver.py
Project Member

Comment 28 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ca78d704b6bec5f2c088028c50d99bc47867443c

commit ca78d704b6bec5f2c088028c50d99bc47867443c
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 23:28:09 2016
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ca78d704b6bec5f2c088028c50d99bc47867443c

commit ca78d704b6bec5f2c088028c50d99bc47867443c
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 23:28:09 2016
Project Member

Comment 30 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/8e74c94675b80ce51a4d5ba2e6e356a0f3aa089a

commit 8e74c94675b80ce51a4d5ba2e6e356a0f3aa089a
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 20 23:46:55 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/2ec00f9dcf6f7384d54326427c01c67f5c1a9ac9 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/3e11cab002795b08e77622dd69fecddf72ee926e Clean up steps in Chromedriver recipe. (mikecase@chromium.org)
depot_tools:
  https://crrev.com/b84ce31e435c2ceeec2a4ee44dffb06ca5f70625 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/4278a31afc8618c43ee029b85eba8f5aa3491dc7 Revert of Set proper result (purple/red) for "Uncaught Exception" and "Failure reason" steps (patchset #1 id:1 of https://codereview.chromium.org/2142833002/ ) (martiniss@chromium.org)

R=iannucci@chromium.org,recipe-roller@chromium.org,estaab@chromium.org,mikecase@chromium.org,martiniss@chromium.org,phajdan.jr@chromium.org
BUG=none,627633

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2166153002

[modify] https://crrev.com/8e74c94675b80ce51a4d5ba2e6e356a0f3aa089a/infra/config/recipes.cfg

Comment 31 by samu...@chromium.org, Jul 21 2016

Summary: Convert ChromeDriver Android bot to recipes (was: Chromedriver android bot is failing with "Uncaught Exception: KeyError('got_revision_cp',) ")

Comment 32 by mikec...@chromium.org, Jul 21 2016 

Landed https://codereview.chromium.org/2170903002 which now makes the nested steps nicer. If there is a test failure, the nest step will now show up as Red.

Also fixed a bug that server logs wouldn't be uploaded after a test failure.

See...
https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/29169
...for first run after this change.
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/7871bd5c631f8114df406006bad578755042f820

commit 7871bd5c631f8114df406006bad578755042f820
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 21 15:28:23 2016
Project Member

Comment 34 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/430fa14b4178317246b45eac9a6930d5958f5fe5

commit 430fa14b4178317246b45eac9a6930d5958f5fe5
Author: recipe-roller <recipe-roller@chromium.org>
Date: Thu Jul 21 15:58:40 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/bbfbad4ff1c20c25e0b3df42fd30c5d0b69e154b chromium_tests: use correct cwd for deapplying patch (phajdan.jr@chromium.org)
  https://crrev.com/e222f56e1e92b532e577cdc36f9e60543aef6e98 chromium.fyi: use chromium recipe in chromium/src via gitiles on remote_run builders (phajdan.jr@chromium.org)
  https://crrev.com/f91d5337a0d67c79c22ce9ebb71d00e19161e724 Reland of [Android] Enable platform mode for perf tests on Galaxy S5 (patchset #1 id:1 of https://codereview.chromium.org/2172463002/ ) (rnephew@chromium.org)
  https://crrev.com/1160d66500b544685e537800c77a4071e35912da Set nest step status when test failure for Chromedriver recipe. (mikecase@chromium.org)

R=rnephew@chromium.org,jbudorick@chromium.org,stip@chromium.org,dtu@chromium.org,mikecase@chromium.org,phajdan.jr@chromium.org
BUG= 627633 , 630065 ,584079, 615157 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2166043006

[modify] https://crrev.com/430fa14b4178317246b45eac9a6930d5958f5fe5/infra/config/recipes.cfg
Project Member

Comment 35 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/1160d66500b544685e537800c77a4071e35912da

commit 1160d66500b544685e537800c77a4071e35912da
Author: mikecase <mikecase@chromium.org>
Date: Thu Jul 21 15:23:05 2016

Set nest step status when test failure for Chromedriver recipe.

Setting the nest step status to FAILURE if the test in the nested
step fails. Also, fix to bug where server logs would never get
uploaded on test failures.

BUG= 627633 

Review-Url: https://codereview.chromium.org/2170903002

[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipe_modules/chromedriver/api.py
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_test_failure.json
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipe_modules/chromedriver/example.py
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
[modify] https://crrev.com/1160d66500b544685e537800c77a4071e35912da/scripts/slave/recipes/chromedriver.py

Comment 36 by mikec...@chromium.org, Jul 22 2016

Status: Fixed (was: Started)
Bot has been consistently green for past day.

Seems to be uploading test results and server logs properly.

Marking as fixed. Feel free to reopen if there is something you think isn't working or needs to be improved.

Comment 37 by jbudorick@chromium.org, Jul 22 2016 

\o/ hooray!

Comment 38 by mikec...@chromium.org, Jul 22 2016 

Ooooooh, one thing I just found. The Download Prebuilt function seems to be downloading the incorrect prebuilt.

It lists out the builds
  .
  .
  16687888  2016-07-21T23:16:09Z  gs://chromedriver-data/prebuilts/r406983.zip
  16687888  2016-07-22T00:16:28Z  gs://chromedriver-data/prebuilts/r407000.zip
  16687888  2016-07-22T01:17:03Z  gs://chromedriver-data/prebuilts/r407004.zip
  16687888  2016-07-22T03:18:58Z  gs://chromedriver-data/prebuilts/r407005.zip
  16542733  2016-07-01T15:56:06Z  gs://chromedriver-data/prebuilts/rNone.zip

Then decides rNone.zip is the "latest" prebuilt, so downloads that one.
/b/build/scripts/slave/gsutil cp gs://chromedriver-data/prebuilts/rNone.zip /tmp/prebuiltZmLUJm/build.zip

However, the implementation is exactly the same as before (using gsutil_download.DownloadLatestFile). So maybe this has always been the case? Anyway, you might want to delete rNone.zip from the Google Bucket.

Link to step
https://build.chromium.org/p/chromium.fyi/builders/Android%20ChromeDriver%20Tests%20%28dbg%29/builds/29187/steps/Download%20Prebuilts.download%20latest%20prebuilt/logs/stdio

Comment 39 by samu...@chromium.org, Jul 22 2016 

Wow, that's...really bad. Looks like this might've been happening since the start of the month. Luckily we haven't released between then and now.

$ gsutil.py ls -l gs://chromedriver-data/prebuilts/rNone.zip
  16542733  2016-07-01T15:56:06Z  gs://chromedriver-data/prebuilts/rNone.zip

I've just deleted it. Maybe we should have some logic in the recipe to catch it?
Project Member

Comment 40 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28

commit fa851a0dcddcbcec44c27e4988dbbcd9c1679a28
Author: mikecase <mikecase@chromium.org>
Date: Tue Jul 26 15:19:09 2016

Add a check that the Chromedriver prebuilt name is expected.

There was a recent issue where the gsutil_download.DownloadLatest
function was grabbing a chromedriver prebuilt named rNone.zip.
This CL ensures that the prebuilt downloaded matches the expected
format.

BUG= 627633 

Review-Url: https://codereview.chromium.org/2181693004

[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/__init__.py
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/api.py
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_basic.json
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_commit_already_in_logs.json
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_download_logs_failure.json
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_test_failure.json
[add] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/example.expected/Android_ChromeDriver_unexpected_prebuilt.json
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipe_modules/chromedriver/example.py
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json
[modify] https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28/scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json
Project Member

Comment 41 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/89a50e3cb5bc38f9e8cf40dc123895d3b1bbb59f

commit 89a50e3cb5bc38f9e8cf40dc123895d3b1bbb59f
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Jul 26 15:36:31 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/fa851a0dcddcbcec44c27e4988dbbcd9c1679a28 Add a check that the Chromedriver prebuilt name is expected. (mikecase@chromium.org)

R=mikecase@chromium.org
BUG= 627633 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2184513004

[modify] https://crrev.com/89a50e3cb5bc38f9e8cf40dc123895d3b1bbb59f/infra/config/recipes.cfg
►

Sign in to add a comment