New issue
Advanced search Search tips

Issue 627632 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 619729



Sign in to add a comment

Introduce a SurfaceTextureFrameProvider

Project Member Reported by tguilbert@chromium.org, Jul 12 2016

Issue description

The initial MediaPlayerRenderer prototype used SurfaceView (see: https://codereview.chromium.org/2075303002/). This has the disadvantage of only allowing fullscreen playback.

Using a SurfaceTexture would allow both fullscreen and non fullscreen playback.

The proposed method of introducing SurfaceTextures by re-using StreamTextures, and effectively encapsulating that portion of WebMediaPlayerAndroid in its own class.

 
Blocking: 619729
Labels: -Pri-2 Pri-1
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed89c4109f83c56b60ede3e3c0b615c20feef37

commit 1ed89c4109f83c56b60ede3e3c0b615c20feef37
Author: tguilbert <tguilbert@chromium.org>
Date: Wed Jul 27 23:50:02 2016

Add StreamTextureWrapperImpl

This change introduces the StreamTextureWrapper interface and its
implementation. It is meant to be used as an alternative way to provide
an Android Surface to the upcoming MediaPlayerRenderer
(see  crbug.com/631199 ). The main advantage of using a StreamTexture is
that it allows non-fullscreen playback, as opposed to the SurfaceView.
The actual transfering of the underlying SurfaceTexture accross
processes will be covered in  crbug.com/627658 .

The StreamTextureWrapper class encapsulates most of the StreamTexture
logic from WMPA.

TEST=video works in current MediaPlayerRenderer prototype. Added a simple contruction/destruction UT for STW_Impl.
BUG= 627632 

Review-Url: https://codereview.chromium.org/2136103010
Cr-Commit-Position: refs/heads/master@{#408279}

[modify] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/content/content_renderer.gypi
[modify] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/content/content_tests.gypi
[modify] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/content/renderer/media/android/stream_texture_factory.h
[add] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/content/renderer/media/android/stream_texture_wrapper_impl.cc
[add] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/content/renderer/media/android/stream_texture_wrapper_impl.h
[add] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/content/renderer/media/android/stream_texture_wrapper_impl_unittest.cc
[modify] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/media/blink/BUILD.gn
[add] https://crrev.com/1ed89c4109f83c56b60ede3e3c0b615c20feef37/media/blink/stream_texture_wrapper.h

Status: Fixed (was: Started)

Sign in to add a comment