New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 627618 link

Starred by 4 users
Status: Assigned
Owner:
█ seanpaul@chromium.org
Last visit > 30 days ago
Cc:
█ ravisadineni@chromium.org
█ marc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 703250


Sign in to add a comment

drm: i915: Add i915_crtc_errors accounting to 3.18 & 4.4 kernels

Project Member Reported by tbroch@chromium.org, Jul 12 2016 
CL: https://chromium-review.googlesource.com/#/c/320931/

  CHROMIUM: drm/i915: Count flip/mode_set errors on crtcs
 
  In intel_crtc, store the number of flip or mode_set errors (well,
  some of them, for now), and expose them via debugfs.

  BUG= chromium:561014 
  TEST=Tested on samus, triggered errors with repro in  crbug.com/568176#c14 

Added debugfs accounting for some common errors to strengthen integration testing around dark resume.  Need to forward port these patches to 3.18 & 4.4 i915 drivers.

Sean is this something you have time for in or can you suggest someone?  Unfortunately and as probably expected its not a trivial cpick ... at least from 3.14 -> 3.18

As far as priority the 3.18 port is higher priority IMO.  4.4 can likely wait for >=M-55
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 22 2016

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/10a27b8fa6b26be1bae19af645ad1644b73510a7

commit 10a27b8fa6b26be1bae19af645ad1644b73510a7
Author: Sean Paul <seanpaul@chromium.org>
Date: Fri Jan 08 21:19:30 2016

CHROMIUM: drm/i915: Count flip/mode_set errors on crtcs

In intel_crtc, store the number of flip or mode_set errors (well,
some of them, for now), and expose them via debugfs.

BUG=chromium:627618
TEST=Compiles

Change-Id: Ie5d05a84c17c9c65c63c421e2c8f871814123168
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/360431
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/10a27b8fa6b26be1bae19af645ad1644b73510a7/drivers/gpu/drm/i915/intel_display.c
[modify] https://crrev.com/10a27b8fa6b26be1bae19af645ad1644b73510a7/drivers/gpu/drm/i915/i915_debugfs.c
[modify] https://crrev.com/10a27b8fa6b26be1bae19af645ad1644b73510a7/drivers/gpu/drm/i915/intel_sprite.c
[modify] https://crrev.com/10a27b8fa6b26be1bae19af645ad1644b73510a7/drivers/gpu/drm/i915/intel_drv.h

Comment 2 by keta...@chromium.org, Feb 17 2017

Status: Archived (was: Assigned)

Comment 3 by ketakid@google.com, Mar 18 2017

Labels: Pri-3
Status: Available (was: Archived)
Activating. Please assign to the right owner and the appropriate priority.
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 12 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by tbroch@chromium.org, Apr 12 2018

Cc: ravisadineni@chromium.org
Status: Assigned (was: Untriaged)
Need to determine if this patch & test that relies on it, power_DarkResumeDisplay, is still useful for catching display related dark resume issues.

If it is then we'll need to port to 4.4 & 4.14 to support dark resume release on devices there.

Comment 6 by tbroch@chromium.org, Apr 12 2018

Components: OS>Kernel>Power

Comment 7 by tbroch@chromium.org, May 21 2018

Blockedon: 703250
►

Sign in to add a comment