On android, if user pauses an incognito download(leaving the incognito tab open), there is no way to resume the download
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e27efd43ed0ee9ed0c45cd88293536697ab747f5 commit e27efd43ed0ee9ed0c45cd88293536697ab747f5 Author: qinmin <qinmin@chromium.org> Date: Tue Jul 26 00:04:55 2016 Allow user to pause/resume incognito downloads This CL includes the following fixes: 1. When an incognito download is paused, Chrome currently shows a cancel button on Android. There is no way for user to resume the download. However, user can pause and resume incognito download on desktop chrome. This change fixes the above behavior to allow paused incognito download to resume. It also fixes an issue that wrong profile is used when canceling/pausing incognito downloads. 2.The CL fixes the usage of isResumable(bad naming) field in DownloadSharedPreferenceEntry. When a download starts, isResumable is set to !isOffTheRecord. And this CL renames isResumable to isPublic in DownloadSharedPreferenceEntry. The isPublic field allows chrome to determine if a download should fail when browser is killed. 3. When a download is paused, we still need an isResumable(correct naming) variable due to the reason of interruption. So this CL separates download interruption handling from download pausing in DownloadManagerService. BUG= 627613 Review-Url: https://codereview.chromium.org/2160063002 Cr-Commit-Position: refs/heads/master@{#407640} [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadController.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadSharedPreferenceEntry.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/android/javatests/src/org/chromium/chrome/browser/download/MockDownloadNotificationService.java [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/browser/android/download/download_manager_service.cc [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/browser/android/download/download_manager_service.h [modify] https://crrev.com/e27efd43ed0ee9ed0c45cd88293536697ab747f5/chrome/browser/android/download/download_manager_service_unittest.cc
Comment 1 by krav...@chromium.org
, Jul 13 2016